Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMarkup: update `es6num` comments in Section 25 #1235
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ljharb
Jun 17, 2018
Member
No, these should never be updated or added - they’re set in stone to preserve ES6-era links.
|
No, these should never be updated or added - they’re set in stone to preserve ES6-era links. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jmdyck
Jun 17, 2018
Collaborator
they’re set in stone to preserve ES6-era links
I'm pretty sure that's not the case: they could be removed without breaking links from any era.
If the editors would prefer them gone (to avoid such questions in the future), I can submit a PR.
I'm pretty sure that's not the case: they could be removed without breaking links from any era. If the editors would prefer them gone (to avoid such questions in the future), I can submit a PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ryzokuken
Jun 18, 2018
Contributor
No, these should never be updated or added - they’re set in stone to preserve ES6-era links.
Making appropriate changes in #1234
Making appropriate changes in #1234 |
ryzokuken
referenced this issue
Jun 18, 2018
Open
Editorial: move Section 25.6 Promise Objects #1234
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
No, links from es6 must work for all eternity. Cool urls never change. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ryzokuken
closed this
Jun 18, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jmdyck
Jun 18, 2018
Collaborator
No, links from es6 must work for all eternity.
Sure, but why do you think that has anything to do with these comments?
Do you think the ecmarkup process looks at them and turns them into anchors? (It doesn't.)
Sure, but why do you think that has anything to do with these comments? Do you think the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ljharb
Jun 18, 2018
Member
I did think that, yes. If it doesn’t, then I’m not sure why we bother keeping the comments at all.
|
I did think that, yes. If it doesn’t, then I’m not sure why we bother keeping the comments at all. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ryzokuken
Jun 18, 2018
Contributor
I understand why you'd want to remove the comments altogether, they need to be updated and added and add extra layers without doing anything meaningful, but for one, they help people navigate. When you're neck deep in markup, an indicator telling which section you're currently on helps.
|
I understand why you'd want to remove the comments altogether, they need to be updated and added and add extra layers without doing anything meaningful, but for one, they help people navigate. When you're neck deep in markup, an indicator telling which section you're currently on helps. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
The clause ID does a better job of that though. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ryzokuken
Jun 18, 2018
Contributor
Just noticed, you're right. It does. So, should I just remove all the comments?
|
Just noticed, you're right. It does. So, should I just remove all the comments? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
The editors discussed this; and decided to get rid of them (see #1237) |
ryzokuken commentedJun 17, 2018
The different sub-sections inside Section 25 are annotated using
es6nummarkup comments like<!-- es6num="25.2" -->. However, these comments weren't updated (and added to new sub-sections) when theAsyncvariants of existing entries were added.Should these comments be updated/added wherever necessary?