Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upString.prototype.padCenter, how about that? #1292
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ljharb
Aug 21, 2018
Member
Please read https://github.com/tc39/ecma262/blob/master/CONTRIBUTING.md for how to best suggest new features.
|
Please read https://github.com/tc39/ecma262/blob/master/CONTRIBUTING.md for how to best suggest new features. |
ljharb
closed this
Aug 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rzorzal
Aug 21, 2018
Ok, sorry. I thought we need discussing it before create a pull-request for it.
rzorzal
commented
Aug 21, 2018
|
Ok, sorry. I thought we need discussing it before create a pull-request for it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ljharb
Aug 21, 2018
Member
@rzorzal yes, you’d also need a champion, and generally pull requests for new features aren’t made until stage 3.
|
@rzorzal yes, you’d also need a champion, and generally pull requests for new features aren’t made until stage 3. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rzorzal
Aug 21, 2018
HMM, ok. Only for my understanding, how can I apply it ? I thought everyone can went apply a new conversation for new features. So, for this purpose I need to contact other one to be my "hero" and than he can apply this new feature ?
rzorzal
commented
Aug 21, 2018
|
HMM, ok. Only for my understanding, how can I apply it ? I thought everyone can went apply a new conversation for new features. So, for this purpose I need to contact other one to be my "hero" and than he can apply this new feature ? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ljharb
Aug 21, 2018
Member
You’d need to find a TC39 member willing to champion the proposal; you’d want to start by emailing es-discuss, as noted here
|
You’d need to find a TC39 member willing to champion the proposal; you’d want to start by emailing es-discuss, as noted here |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rzorzal
commented
Aug 21, 2018
|
Thanks a lot, I will send the e-mail right now. |
rzorzal commentedAug 21, 2018
Hello guys, I here to talk about padStart, padEnd and my new proposal "padCenter", I think it is not hard to develop because we already had padStart and padEnd.
I thought that we need to add one more feature to String's prototype, and it is not a hard work. So the proposal is to create the String.prototype.padCenter that centralize a string with a max character lenght, equals we do when call the "pad" functions.
For exemple, when we call padStart
and when we call padEnd:
how about that:
I'm searching it for a long time and I seen people talking about it in different use cases. But for me it will be usefull when I need to send some text data to my bluetooth printer, becouse the length of his line is 32 and I need to centralize the data and adjust the line to right and left.
I think this feature can improve the language and it will be useful for other developers like me.
Although we has libs that has an implementation of it
https://lodash.com/docs#pad
http://gabceb.github.io/underscore.string.site/#pad
https://vocajs.com/#pad
I think it can be done for native functions too
And it is native for other languages, such as:
1. PHP (https://www.w3schools.com/php/showphp.asp?filename=demo_func_string_str_pad3)
2. Python (https://docs.python.org/2/library/string.html#string.center)
3. Ruby (https://ruby-doc.org/core-2.2.0/String.html#center-method)
4. R (https://www.rdocumentation.org/packages/stringr/versions/1.3.1/topics/str_pad)
5. etc...
What do you guys think ?
( We can call it "pad" instead of "padCenter" haha )