Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing description of [[FunctionKind]] internal slot of Function Object. #1308
Comments
ljharb
added
editorial change
spec bug
good first patch
labels
Sep 13, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ljharb
Sep 13, 2018
Member
Fixing the description is good; i don’t have a strong opinion on “asyncGenerator” vs “async generator”, but since it’s not an identifier, there’s no reason it needs to be in camelCase.
|
Fixing the description is good; i don’t have a strong opinion on “asyncGenerator” vs “async generator”, but since it’s not an identifier, there’s no reason it needs to be in camelCase. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ENvironmentSet
Sep 13, 2018
then, just hold current("async generator") would be better. thx for provide opinion.
ENvironmentSet
commented
Sep 13, 2018
|
then, just hold current("async generator") would be better. thx for provide opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ENvironmentSet commentedSep 13, 2018
•
edited
In
FunctionAllocatethere is few logic.So, we can say, F.[[FunctionKind]] can be "async generator".
but, description about [[FunctionKind]] in specification, It isn't
I think, to change this to blow will be better.
PS. why FunctionKind of async generator is "async generator" ? even class constructor is "classConstructor". I think it have to be "asyncGenerator", because specification usually use camel case.