Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSome assert in algorithm description can not be interpreted as a condition. #178
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ljharb
Nov 15, 2015
Member
The assertion there is "items is not an iterable", "assume it is an array-like object" is more like an explanatory note - but I agree this is confusingly worded.
|
The assertion there is "items is not an iterable", "assume it is an array-like object" is more like an explanatory note - but I agree this is confusingly worded. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bterlson
Jan 14, 2016
Member
Asserts are simply used to clarify algorithms. One could argue for these to be notes instead of asserts. I'll change that for the two instances of "items is not an Iterable". Feel free to file bugs for any remaining issues.
|
Asserts are simply used to clarify algorithms. One could argue for these to be notes instead of asserts. I'll change that for the two instances of "items is not an Iterable". Feel free to file bugs for any remaining issues. |
nisiyama commentedNov 15, 2015
[JP22] Foe example, step 7 of “22.1.2.1 Array.from(items [, mapfn [, thisArg ]])” is described as “Assert: items is not an Iterable so assume it is an array-like object.”. This assertion can not be interpreted as a condition.