New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabelledIdentifier is not used when evaluating LabelledStatement #188

Closed
nanto opened this Issue Nov 16, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@nanto

nanto commented Nov 16, 2015

[JP22] In 13.13.15, LabelledIdentifier of LabelledStatement is not used. LabelledIdentifiers are ignored unless the labelled statements are nested. To use LabelledIdentifier, 13.13.15 step 2 can be:

Return LabelledEvaluation of this LabelledStatement with argument newLabelSet.

@allenwb

This comment has been minimized.

Show comment
Hide comment
@allenwb

allenwb Nov 24, 2015

Member

While it is sometimes necessary to apply an abstract operation to a production LHS, it is something that I think can be confusing. To avoid that, instead of the fix suggested above, I would simply add a new step after step one that says:

Append the string value of LabelIdentifier to newLabelSet.
Member

allenwb commented Nov 24, 2015

While it is sometimes necessary to apply an abstract operation to a production LHS, it is something that I think can be confusing. To avoid that, instead of the fix suggested above, I would simply add a new step after step one that says:

Append the string value of LabelIdentifier to newLabelSet.
@anba

This comment has been minimized.

Show comment
Hide comment
@anba

anba Nov 24, 2015

Contributor

Simply appending the label identifier to newLabelSet does not work, because break abrupt completions also need to be handled.

Contributor

anba commented Nov 24, 2015

Simply appending the label identifier to newLabelSet does not work, because break abrupt completions also need to be handled.

@allenwb

This comment has been minimized.

Show comment
Hide comment
@allenwb

allenwb Nov 24, 2015

Member

@anba
Yup, as usual you're correct.

So, the original fix is fine.

Member

allenwb commented Nov 24, 2015

@anba
Yup, as usual you're correct.

So, the original fix is fine.

@nanto

This comment has been minimized.

Show comment
Hide comment
@nanto

nanto Nov 24, 2015

A production LHS is also used in 13.1.8, evaluation of BreakableStatement.

nanto commented Nov 24, 2015

A production LHS is also used in 13.1.8, evaluation of BreakableStatement.

@bterlson bterlson closed this in 246e735 Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment