New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP22: character reference inconsistency in 20.1.3.2, 20.1.3.3 and 20.1.3.5 #199

Closed
akr opened this Issue Nov 17, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@akr

akr commented Nov 17, 2015

In the sections 20.1.3.2 (Number.prototype.toExponential), 20.1.3.3 (Number.prototype.toFixed) and 20.1.3.5 (Number.prototype.toPrecision), characters are referenced inconsistently.
For example, 20.1.3.2 step 13.b. and 20.1.3.3 step 10.c.iv refers a character as "." but
20.1.3.5 step 12.c.iii refers it as "code unit 0x002E (FULL STOP)".

Unicode character names identify the characters more reliably than the character glyphs.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Dec 2, 2015

Member

I tend to think the character names are unnecessary. In this case it'd be pretty easy to use the character name as we're talking about one character, but morally the same would apply to any multi-character strings used in the document. I will fix the inconsistency by making 20.1.3.5 step 12.c.iii use ".".

Member

bterlson commented Dec 2, 2015

I tend to think the character names are unnecessary. In this case it'd be pretty easy to use the character name as we're talking about one character, but morally the same would apply to any multi-character strings used in the document. I will fix the inconsistency by making 20.1.3.5 step 12.c.iii use ".".

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Dec 2, 2015

Member

Removing all mentions of "code unit X (NAME)" would be a good regexp replace someone could do. One concern would be tough-to-read code units like HYPHEN-MINUS, but since we consider the HTML normative now (and printed copies non-normative), and the HTML actually has the code point we want in its source, I think this is fine. What do you think?

Member

bterlson commented Dec 2, 2015

Removing all mentions of "code unit X (NAME)" would be a good regexp replace someone could do. One concern would be tough-to-read code units like HYPHEN-MINUS, but since we consider the HTML normative now (and printed copies non-normative), and the HTML actually has the code point we want in its source, I think this is fine. What do you think?

@bterlson bterlson closed this in 0967d7b Dec 2, 2015

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Dec 2, 2015

Member

Should the string padding proposal then use " " to indicate a single space? Or is the code point helpful there (and should the formatting be tweaked)?

Member

ljharb commented Dec 2, 2015

Should the string padding proposal then use " " to indicate a single space? Or is the code point helpful there (and should the formatting be tweaked)?

@anba

This comment has been minimized.

Show comment
Hide comment
@anba

anba Dec 2, 2015

Contributor

The code unit notation is definitely helpful when U+0020 SPACE is used, for example I didn't realize SIMD ToString uses ", " (U+002C U+0020) instead of "," (U+002C) until running the SIMD test suite.

Contributor

anba commented Dec 2, 2015

The code unit notation is definitely helpful when U+0020 SPACE is used, for example I didn't realize SIMD ToString uses ", " (U+002C U+0020) instead of "," (U+002C) until running the SIMD test suite.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Dec 2, 2015

Member

@anba yeah, totally agreed. "Easily confused" characters should probably continue to use character names (including all form of dashes and spaces).

Member

bterlson commented Dec 2, 2015

@anba yeah, totally agreed. "Easily confused" characters should probably continue to use character names (including all form of dashes and spaces).

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Dec 2, 2015

Member

Is there a formatting convention that should be followed for this case?

Member

ljharb commented Dec 2, 2015

Is there a formatting convention that should be followed for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment