New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trailing slash in GitHub Pages site link, otherwise GitHub redirects to non-https address #231

Closed
UltCombo opened this Issue Dec 6, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@UltCombo
Contributor

UltCombo commented Dec 6, 2015

Currently, the repository description reads:

Status, process, and documents for ECMA262 https://tc39.github.io/ecma262

Clicking on the https://tc39.github.io/ecma262 link will redirect to http://tc39.github.io/ecma262/ (with a trailing slash added, and https removed ❗️).

Please add the trailing slash to the link so it does not perform the unsafe redirect.

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Dec 6, 2015

Member

GitHub pages are always on HTTP, so there's no way to avoid the "unsafe" redirect. (turns out it's only with a custom domain that they're always on http)

Member

ljharb commented Dec 6, 2015

GitHub pages are always on HTTP, so there's no way to avoid the "unsafe" redirect. (turns out it's only with a custom domain that they're always on http)

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Dec 6, 2015

Member

@ljharb https://tc39.github.io/ecma262/ is secure and doesn’t redirect.

Member

mathiasbynens commented Dec 6, 2015

@ljharb https://tc39.github.io/ecma262/ is secure and doesn’t redirect.

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Dec 6, 2015

Member

hm, you're right - i tried curling the various URLs and must have confused myself. You're exactly right. It's very strange that github has that redirect set up.

Member

ljharb commented Dec 6, 2015

hm, you're right - i tried curling the various URLs and must have confused myself. You're exactly right. It's very strange that github has that redirect set up.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Dec 8, 2015

Member

This is garbage behavior.

Member

bterlson commented Dec 8, 2015

This is garbage behavior.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Dec 8, 2015

Member

Fixed.

Member

bterlson commented Dec 8, 2015

Fixed.

@bterlson bterlson closed this Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment