/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B.1.4 AtomEscape production syntax incomplete #378

Closed
hashseed opened this Issue Feb 10, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hashseed @michaelficarra @bterlson
@hashseed

hashseed commented Feb 10, 2016

In http://tc39.github.io/ecma262/#sec-regular-expressions-patterns

AtomEscape[U] ::
[+U] DecimalEscape
[+U] CharacterEscape[U]
[+U] CharacterClassEscape
[~U] DecimalEscape only if the integer value
[~U] CharacterClassEscape
[~U] CharacterEscape

It should be

AtomEscape[U] ::
[+U] DecimalEscape
[+U] CharacterEscape[U]
[+U] CharacterClassEscape
[~U] DecimalEscape but only if the integer value of DecimalEscape is <= NCapturingParens
[~U] CharacterClassEscape
[~U] CharacterEscape

The condition for ~U is necessary so that we can fall back to CharacterEscape, which may interpret the digits as legacy octal escape.
@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Feb 10, 2016

Member

This seems to be another duplicate of #363, #358, #325.
Member

michaelficarra commented Feb 10, 2016

This seems to be another duplicate of #363, #358, #325.
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Feb 17, 2016

Member

Indeed, same issue.
Member

bterlson commented Feb 17, 2016

Indeed, same issue.

@bterlson bterlson closed this Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment