New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerformPromiseThen should unconditionally set [[PromiseIsHandled]] to true #384

Closed
tschneidereit opened this Issue Feb 12, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@tschneidereit
Member

tschneidereit commented Feb 12, 2016

Right now, this only happens if the promise is already rejected. That leads to Promises never being marked as handled in scenarios like the following:

let reject;
const p = new Promise((res, rej)=>{reject = rej});
p2 = p.then(f);
reject();

/cc @domenic

@tschneidereit

This comment has been minimized.

Show comment
Hide comment
@tschneidereit

tschneidereit Feb 12, 2016

Member

Dupe of #383. That went well.

Member

tschneidereit commented Feb 12, 2016

Dupe of #383. That went well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment