/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: "must be true so, let" should be "must be true, so let" #389

Closed
domenic opened this Issue Feb 12, 2016 · 4 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@domenic @ljharb @zenparsing @annevk @bterlson
@domenic
Member

domenic commented Feb 12, 2016

Otherwise, IsAccessorDescriptor(desc) must be true so, let getter be desc.[[Get]].

@domenic domenic added the editorial change label Feb 12, 2016

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Feb 12, 2016

Member

I'd go with "must be true, so, let" since the "let …" is a separately emphasized clause ¯_(ツ)_/¯ 🚲🏠
Member

ljharb commented Feb 12, 2016

I'd go with "must be true, so, let" since the "let …" is a separately emphasized clause ¯_(ツ)_/¯ 🚲🏠
@zenparsing

This comment has been minimized.

Show comment
Hide comment
@zenparsing

zenparsing Feb 12, 2016

Contributor

Or use assert. So many choices!
Contributor

zenparsing commented Feb 12, 2016

Or use assert. So many choices!

@annevk annevk referenced this issue Feb 13, 2016

Merged

Define security around Window, WindowProxy, and Location properly #638

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Feb 23, 2016

Contributor

In HTML we went with "must be true, so let". Happy to provide a PR for ECMAScript if someone wants to call it.
Contributor

annevk commented Feb 23, 2016

In HTML we went with "must be true, so let". Happy to provide a PR for ECMAScript if someone wants to call it.
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Feb 24, 2016

Member

Let's just use assert rather than normalizing another convention.
Member

bterlson commented Feb 24, 2016

Let's just use assert rather than normalizing another convention.

@annevk annevk referenced this issue Feb 25, 2016

Merged

Editorial: Use assert rather than "must be true" #415

@bterlson bterlson closed this in #415 Feb 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment