New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an abstract operation for the latter part of OrdinarySet #566

Closed
Ms2ger opened this Issue May 11, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@Ms2ger

Ms2ger commented May 11, 2016

WebIDL uses

Perform steps 3-11 of the default [[Set]] internal method ([ECMA-262], section 9.1.9).

because it wants to replace the definition of ownDesc. It would be better to have an explicit operation for it to call.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic May 11, 2016

Member

I think it'd be best if Web IDL just copied the appropriate steps, actually. There's no clear factoring here. (Also, that is outdated, as there are only 9 steps in what is now called OrdinarySet.)

Member

domenic commented May 11, 2016

I think it'd be best if Web IDL just copied the appropriate steps, actually. There's no clear factoring here. (Also, that is outdated, as there are only 9 steps in what is now called OrdinarySet.)

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk May 11, 2016

Contributor

IDL should probably also be rewritten for this since it seems the complexity is only warranted for objects supporting indexed properties. Better to isolate those from the ordinary objects.

Contributor

annevk commented May 11, 2016

IDL should probably also be rewritten for this since it seems the complexity is only warranted for objects supporting indexed properties. Better to isolate those from the ordinary objects.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson May 11, 2016

Member

Going to go with Domenic's recommendation :-P Feel free to re-open though!

Member

bterlson commented May 11, 2016

Going to go with Domenic's recommendation :-P Feel free to re-open though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment