New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword list does not have line breaks. #64

Closed
mysticatea opened this Issue Sep 23, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@mysticatea
Contributor

mysticatea commented Sep 23, 2015

http://tc39.github.io/ecma262/#prod-Keyword

image

Windows 7, Chrome 46.0.2490.33, Firefox 42.0a2.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Sep 23, 2015

Member

Nice find... because the non-terminal elements don't have spaces between them they don't break. Maybe the right approach is for emu to put \u200A HAIR SPACE between non-terminals or something. Will think about this.

Member

bterlson commented Sep 23, 2015

Nice find... because the non-terminal elements don't have spaces between them they don't break. Maybe the right approach is for emu to put \u200A HAIR SPACE between non-terminals or something. Will think about this.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Sep 24, 2015

Member

Why hair space? Is there no zero-width way to allow a break? If not, a regular space is probably fine since the margin on each of the emu-ts is larger than a space.

Member

michaelficarra commented Sep 24, 2015

Why hair space? Is there no zero-width way to allow a break? If not, a regular space is probably fine since the margin on each of the emu-ts is larger than a space.

@mysticatea

This comment has been minimized.

Show comment
Hide comment
@mysticatea

mysticatea Sep 24, 2015

Contributor

Also, I have found a wrong line break in the Punctuator list.

image

So my idea is:

  emu-t {
      font-family: monospace;
      font-weight: bold;
+     white-space: nowrap;
  }

- emu-production emu-t {
-     margin-right: 1ex;
+ emu-production emu-t::after {
+     content: " ";
+     white-space: normal;
  }

image
image

Contributor

mysticatea commented Sep 24, 2015

Also, I have found a wrong line break in the Punctuator list.

image

So my idea is:

  emu-t {
      font-family: monospace;
      font-weight: bold;
+     white-space: nowrap;
  }

- emu-production emu-t {
-     margin-right: 1ex;
+ emu-production emu-t::after {
+     content: " ";
+     white-space: normal;
  }

image
image

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Sep 24, 2015

Member

Looks nice to me. Does it look ok with other productions that have non-terminals next to terminals? If so, want to send a PR to Ecmarkup? :)

Member

bterlson commented Sep 24, 2015

Looks nice to me. Does it look ok with other productions that have non-terminals next to terminals? If so, want to send a PR to Ecmarkup? :)

@mysticatea

This comment has been minimized.

Show comment
Hide comment
@mysticatea

mysticatea Sep 24, 2015

Contributor

Does it look ok with other productions that have non-terminals next to terminals?

Looks OK to me.

image

If so, want to send a PR to Ecmarkup?

Yes, I will do :)

Contributor

mysticatea commented Sep 24, 2015

Does it look ok with other productions that have non-terminals next to terminals?

Looks OK to me.

image

If so, want to send a PR to Ecmarkup?

Yes, I will do :)

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Sep 24, 2015

Member

Awesome, looks great! I can commit this tomorrow too if you don't get around to it.

Member

bterlson commented Sep 24, 2015

Awesome, looks great! I can commit this tomorrow too if you don't get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment