New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Function.prototype.toString` revision #664

Open
mathiasbynens opened this Issue Aug 12, 2016 · 9 comments

Comments

Projects
None yet
7 participants
@mathiasbynens
Member

mathiasbynens commented Aug 12, 2016

https://github.com/tc39/Function-prototype-toString-revision by @michaelficarra

Please tag this issue with the “web reality” label. Thanks!

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Aug 15, 2016

Member

Let's leave this open until the proposal has been merged into the main spec, so that people looking at https://github.com/tc39/ecma262/labels/web%20reality can get a better view.

Member

domenic commented Aug 15, 2016

Let's leave this open until the proposal has been merged into the main spec, so that people looking at https://github.com/tc39/ecma262/labels/web%20reality can get a better view.

@domenic domenic reopened this Aug 15, 2016

@littledan

This comment has been minimized.

Show comment
Hide comment
@littledan

littledan Aug 17, 2016

Member

I don't think @michaelficarra 's proposal reflects current web reality, as it is not what any particular browser currently ships, as far as I know.

Member

littledan commented Aug 17, 2016

I don't think @michaelficarra 's proposal reflects current web reality, as it is not what any particular browser currently ships, as far as I know.

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Aug 17, 2016

Member

My understanding is that there is a significant percentage that intersects web reality, and for the rest, there isn't cross-browser agreement.

@michaelficarra could you post/point to the data from your presentation about that?

Member

ljharb commented Aug 17, 2016

My understanding is that there is a significant percentage that intersects web reality, and for the rest, there isn't cross-browser agreement.

@michaelficarra could you post/point to the data from your presentation about that?

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Aug 18, 2016

Member

@ljharb

screen shot 2016-08-18 at 03 22 20

Yeah, I don't think that the Function.prototype.toString proposal differs from web reality. It just makes even stronger guarantees than both what was specified and what exists in implementations.

Member

michaelficarra commented Aug 18, 2016

@ljharb

screen shot 2016-08-18 at 03 22 20

Yeah, I don't think that the Function.prototype.toString proposal differs from web reality. It just makes even stronger guarantees than both what was specified and what exists in implementations.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Aug 18, 2016

Member

By the way, this is why we have stage 3. We're waiting on implementation feedback to confirm that this is both technically feasible and web compatible before moving it to stage 4.

Member

michaelficarra commented Aug 18, 2016

By the way, this is why we have stage 3. We're waiting on implementation feedback to confirm that this is both technically feasible and web compatible before moving it to stage 4.

@bakkot

This comment has been minimized.

Show comment
Hide comment
@bakkot

bakkot Aug 18, 2016

Contributor

fwiw, I believe the proposal disagrees from web reality in its treatment of source text occurring prior to the formal parameters in normal function expressions and declarations.

Contributor

bakkot commented Aug 18, 2016

fwiw, I believe the proposal disagrees from web reality in its treatment of source text occurring prior to the formal parameters in normal function expressions and declarations.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Aug 18, 2016

Member

@bakkot That's right. I should have said that I believe it is web compatible. So technically different, but not in a way that will break a meaningful number of web pages. But we'll have to wait for implementation feedback (hint, nudge, wink, etc.) before we know this to be true.

Member

michaelficarra commented Aug 18, 2016

@bakkot That's right. I should have said that I believe it is web compatible. So technically different, but not in a way that will break a meaningful number of web pages. But we'll have to wait for implementation feedback (hint, nudge, wink, etc.) before we know this to be true.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Aug 18, 2016

Member

@bakkot That change makes sense as it places the proposal consistent with it self.

As @ljharb mentioned: "... there is a significant percentage that intersects web reality, ...", which seems reasonable.

Member

leobalter commented Aug 18, 2016

@bakkot That change makes sense as it places the proposal consistent with it self.

As @ljharb mentioned: "... there is a significant percentage that intersects web reality, ...", which seems reasonable.

@bakkot

This comment has been minimized.

Show comment
Hide comment
@bakkot

bakkot Aug 18, 2016

Contributor

Sure. Just wanted to clarify that "for the rest, there isn't cross-browser agreement" wasn't quite right.

Contributor

bakkot commented Aug 18, 2016

Sure. Just wanted to clarify that "for the rest, there isn't cross-browser agreement" wasn't quite right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment