New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.prototype.values is not fully web compatible #695

Closed
evilpie opened this Issue Sep 21, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@evilpie
Contributor

evilpie commented Sep 21, 2016

Apparently "Microsoft Dynamics CRM 2011" breaks when Array.prototype.values exists. From what I understand Chrome landed Array#values at two different times and removed it again. Current Chrome versions don't have Array#values anymore (issue 615873). This bug has been known since 2014 and there apparently is an update to that CRM software (http://www.crmanswers.net/2014/10/lookup-errors-with-google-chrome-38.html). I am looking into removing Array.prototype.values from Firefox stable again (bug 1299593). The Chrome issue claims Safari is shipping this feature already. To my knowledge we haven't heard from any other breakage, so I am still optimistic we can land this at some point.

@chicoxyzzy

This comment has been minimized.

Show comment
Hide comment
@chicoxyzzy

chicoxyzzy Sep 22, 2016

Contributor

According to compat-table's test Edge does have Array.prototype.values so seems like MS doesn't care about Dynamics CRM 2011. So I don't see any reason to remove this feature from Firefox stable

Contributor

chicoxyzzy commented Sep 22, 2016

According to compat-table's test Edge does have Array.prototype.values so seems like MS doesn't care about Dynamics CRM 2011. So I don't see any reason to remove this feature from Firefox stable

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Sep 22, 2016

Member

@chicoxyzzy we have it shipped, yes. However it's possible we are somewhat saved by a GP setting that allows corps to direct users to IE11 for certain old intranet applications.

Member

bterlson commented Sep 22, 2016

@chicoxyzzy we have it shipped, yes. However it's possible we are somewhat saved by a GP setting that allows corps to direct users to IE11 for certain old intranet applications.

@claudepache

This comment has been minimized.

Show comment
Hide comment
@claudepache

claudepache Sep 22, 2016

Contributor

@chicoxyzzy According to your compat-table, Edge has supported Array#values() since its first release; so it's not as if it supported Dynamics CRM 2011 once, and later broke it in an update like Firefox and Chrome.

Contributor

claudepache commented Sep 22, 2016

@chicoxyzzy According to your compat-table, Edge has supported Array#values() since its first release; so it's not as if it supported Dynamics CRM 2011 once, and later broke it in an update like Firefox and Chrome.

TimothyGu added a commit to TimothyGu/webidl2js that referenced this issue Aug 21, 2017

Do not use Array.prototype.values
Use Array.prototype[@@iterator] instead because of
tc39/ecma262#695.

domenic added a commit to jsdom/webidl2js that referenced this issue Aug 21, 2017

Do not use Array.prototype.values
Use Array.prototype[@@iterator] instead because of
tc39/ecma262#695.
@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Mar 21, 2018

Member

Chrome 66 in April, and Firefox 60 in May, will both re-enable Array.prototype.values, at which point this can be closed.

Member

ljharb commented Mar 21, 2018

Chrome 66 in April, and Firefox 60 in May, will both re-enable Array.prototype.values, at which point this can be closed.

@evilpie

This comment has been minimized.

Show comment
Hide comment
@evilpie

evilpie Jun 19, 2018

Contributor

I guess we can close this now. Discussing this with @gsathya he mentioned that they saw some minor breakage in Chrome, but don't plan on disabling it again. I didn't see any breakage with Firefox, so we don't have any plans for removing this either.

Contributor

evilpie commented Jun 19, 2018

I guess we can close this now. Discussing this with @gsathya he mentioned that they saw some minor breakage in Chrome, but don't plan on disabling it again. I didn't see any breakage with Firefox, so we don't have any plans for removing this either.

@evilpie evilpie closed this Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment