New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDL needs hook for subset of OrdinarySet #719

Closed
annevk opened this Issue Oct 25, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@annevk
Contributor

annevk commented Oct 25, 2016

For heycam/webidl#201 we need a way to invoke step 3-onward of OrdinarySet.

Would something like OrdinarySetWithOwnDesc(O, P, V, Reciever, ownDesc) be okay? Should this new abstract operation be a subsection or sibling section of OrdinarySet?

@Ms2ger

This comment has been minimized.

Show comment
Hide comment
@Ms2ger

Ms2ger commented Oct 25, 2016

So like #566?

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Oct 25, 2016

Member

Welp. Um, I guess I've reversed my position since #566, and think that we should indeed factor it out.

The alternative would be to add a giant warning in the ES source code like <!-- FILE AN ISSUE ON WEB IDL BEFORE CHANGING THIS IN ANY WAY -->, but I think a refactoring would probably be clearer.

Member

domenic commented Oct 25, 2016

Welp. Um, I guess I've reversed my position since #566, and think that we should indeed factor it out.

The alternative would be to add a giant warning in the ES source code like <!-- FILE AN ISSUE ON WEB IDL BEFORE CHANGING THIS IN ANY WAY -->, but I think a refactoring would probably be clearer.

TimothyGu added a commit to TimothyGu/ecma262 that referenced this issue Sep 7, 2017

@bterlson bterlson closed this in #992 Sep 7, 2017

bterlson added a commit that referenced this issue Sep 7, 2017

Editorial: Create OrdinarySetWithOwnDescriptor (#992)
Closes #719. Needed for inbound WebIDL references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment