/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateDynamicFunction is not correct for async function prototypes #751

Closed
domenic opened this Issue Dec 9, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@domenic @bterlson
@domenic
Member

domenic commented Dec 9, 2016

That is, the issue mentioned in #692 (comment) was never fixed.

@bterlson bterlson closed this in 023da9d Dec 29, 2016

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Dec 29, 2016

Member

You also need to fix the note:

A prototype property is automatically created for every function created using CreateDynamicFunction, to provide for the possibility that the function will be used as a constructor.
Member

domenic commented Dec 29, 2016

You also need to fix the note:

A prototype property is automatically created for every function created using CreateDynamicFunction, to provide for the possibility that the function will be used as a constructor.

@domenic domenic reopened this Dec 29, 2016

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Dec 29, 2016

Member

It's a weird note, but I'll update it.
Member

bterlson commented Dec 29, 2016

It's a weird note, but I'll update it.

@bterlson bterlson closed this in 5ce3a49 Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment