FunctionDeclarationInstantiation always returns a normal completion ?

[jmdyck]

Commit c90286d says that FunctionDeclarationInstantiation always returns a normal completion, and inserts '!' in front of two invocations of it (here and here).

Presumably this assertion is not true in general, since FDI has calls to IteratorBindingInitialization that are prefixed by '?'.

If the intent was merely that those two invocations always return normally, then:
(a) What causes that to be true?
(b) The if-then-else following each invocation could be simplified, since it tests whether the result of FDI is abrupt.

[anba]

Agreed, c90286d should be reverted because FDI can return abrupt completions for the reasons outlined above.

[anba]

Agreed, c90286d should be reverted because FDI can return abrupt completions for the reasons outlined above.

[jmdyck]

Note that simply reverting that commit will leave one of the invocations with a '?' prefix, which doesn't make sense given the if-then-else that follows. I believe the proper fix is to delete both '!' prefixes.

[jmdyck]

Note that simply reverting that commit will leave one of the invocations with a '?' prefix, which doesn't make sense given the if-then-else that follows. I believe the proper fix is to delete both '!' prefixes.