Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upInconsistent spacing around binary operators #925
Comments
domenic
added
the
editorial change
label
May 30, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dantesolis
Nov 21, 2017
hey guys, could I work on this issue, is this a good issue for a first-time contributor or should I take something else? Thanks
dantesolis
commented
Nov 21, 2017
|
hey guys, could I work on this issue, is this a good issue for a |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
littledan
Nov 21, 2017
Member
@dantesolis Go for it! I think an editorial patch like this would be great for a first-time contributor. You can do this by editing the spec.html file in this repository and making a PR on GitHub. Feel free to ask questions here or on the #tc39 channel on Freenode IRC.
|
@dantesolis Go for it! I think an editorial patch like this would be great for a first-time contributor. You can do this by editing the spec.html file in this repository and making a PR on GitHub. Feel free to ask questions here or on the #tc39 channel on Freenode IRC. |
mathiasbynens
referenced this issue
Dec 21, 2017
Merged
[Normative] Add RegExp named capture groups #1027
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@dantesolis are you still hoping to take this on? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
If not, I'll do it. |
ljharb
added
the
good first patch
label
Apr 1, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
littledan
Apr 4, 2018
Member
@jmdyck Go for it. I also ran into this in the mathematical values change.
|
@jmdyck Go for it. I also ran into this in the mathematical values change. |
domenic commentedMay 30, 2017
•
edited
Mostly there seems to be space between binary operators and their operands, e.g.
Repeat, while q ≠ s,If e = p, etc. But sometimes there is no spacing, e.g. the latter half ofIf e = p, let q be q+1, or the former half ofIf q+r > s.Obviously very minor, but I think cleaning this up to add spaces everywhere would be good.