New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent spacing around binary operators #925

Closed
domenic opened this Issue May 30, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@domenic
Member

domenic commented May 30, 2017

Mostly there seems to be space between binary operators and their operands, e.g. Repeat, while q ≠ s, If e = p, etc. But sometimes there is no spacing, e.g. the latter half of If e = p, let q be q+1, or the former half of If q+r > s.

Obviously very minor, but I think cleaning this up to add spaces everywhere would be good.

@dantesolis

This comment has been minimized.

Show comment
Hide comment
@dantesolis

dantesolis Nov 21, 2017

hey guys, could I work on this issue, is this a good issue for a first-time contributor or should I take something else? Thanks

dantesolis commented Nov 21, 2017

hey guys, could I work on this issue, is this a good issue for a first-time contributor or should I take something else? Thanks

@littledan

This comment has been minimized.

Show comment
Hide comment
@littledan

littledan Nov 21, 2017

Member

@dantesolis Go for it! I think an editorial patch like this would be great for a first-time contributor. You can do this by editing the spec.html file in this repository and making a PR on GitHub. Feel free to ask questions here or on the #tc39 channel on Freenode IRC.

Member

littledan commented Nov 21, 2017

@dantesolis Go for it! I think an editorial patch like this would be great for a first-time contributor. You can do this by editing the spec.html file in this repository and making a PR on GitHub. Feel free to ask questions here or on the #tc39 channel on Freenode IRC.

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Mar 21, 2018

Member

@dantesolis are you still hoping to take this on?

Member

ljharb commented Mar 21, 2018

@dantesolis are you still hoping to take this on?

@jmdyck

This comment has been minimized.

Show comment
Hide comment
@jmdyck

jmdyck Mar 22, 2018

Collaborator

If not, I'll do it.

Collaborator

jmdyck commented Mar 22, 2018

If not, I'll do it.

@littledan

This comment has been minimized.

Show comment
Hide comment
@littledan

littledan Apr 4, 2018

Member

@jmdyck Go for it. I also ran into this in the mathematical values change.

Member

littledan commented Apr 4, 2018

@jmdyck Go for it. I also ran into this in the mathematical values change.

jmdyck added a commit to jmdyck/ecma262 that referenced this issue Apr 5, 2018

jmdyck added a commit to jmdyck/ecma262 that referenced this issue Jul 7, 2018

@ljharb ljharb closed this in e8727ee Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment