/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Entities not rendering in UnicodeIDStart, UnicodeIDContinue #931

Closed
rwaldron opened this Issue Jun 13, 2017 · 5 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rwaldron @mathiasbynens @bterlson
@rwaldron
Contributor

rwaldron commented Jun 13, 2017 

UnicodeIDStart::
    any Unicode code point with the Unicode property “ID_Start”
UnicodeIDContinue::
    any Unicode code point with the Unicode property “ID_Continue”

https://tc39.github.io/ecma262/#prod-UnicodeIDStart
@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Jun 13, 2017

Member

bterlson/ecmarkup#117
Member

mathiasbynens commented Jun 13, 2017 •
edited

bterlson/ecmarkup#117

@mathiasbynens mathiasbynens closed this Jun 13, 2017

@rwaldron

This comment has been minimized.

Show comment
Hide comment
@rwaldron

rwaldron Jun 13, 2017

Contributor

@mathiasbynens ah, thanks! ❤️
Contributor

rwaldron commented Jun 13, 2017

@mathiasbynens ah, thanks! ❤️
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Jun 13, 2017

Member

I'll try to get to this today, I have discussed a possible fix with @rbuckton that should be fairly easy to implement.
Member

bterlson commented Jun 13, 2017

I'll try to get to this today, I have discussed a possible fix with @rbuckton that should be fairly easy to implement.
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Jun 13, 2017

Member

Involving yet another @mathiasbynens's library, of course (in this case, "he"). Idea is in cases where we slice the source text to pass to grammarkdown we first decode HTML entities (other code paths where we don't slice the source text use innerHTML and so get decoded for us)
Member

bterlson commented Jun 13, 2017 •
edited

Involving yet another @mathiasbynens's library, of course (in this case, "he"). Idea is in cases where we slice the source text to pass to grammarkdown we first decode HTML entities (other code paths where we don't slice the source text use innerHTML and so get decoded for us)
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Jun 13, 2017

Member

Fixed bterlson/ecmarkup#117.
Member

bterlson commented Jun 13, 2017

Fixed bterlson/ecmarkup#117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment