/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing GetValue() in 12.2.9.6 (TemplateLiteral Evaluation) #935

Closed
kotarondo opened this Issue Jun 17, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kotarondo
@kotarondo

kotarondo commented Jun 17, 2017

In 12.2.9.6 (TemplateLiteral Evaluation)

GetValue() are missing after the line:
Let sub be the result of evaluating Expression.

for the productions:
TemplateLiteral: TemplateHead Expression TemplateSpans
TemplateMiddleList: TemplateMiddle Expression
TemplateMiddleList: TemplateMiddleList TemplateMiddle Expression

TimothyGu added a commit to TimothyGu/ecma262 that referenced this issue Aug 30, 2018

@TimothyGu
Normative: Add missing GetValue() to TemplateLiteral evaluation 
As currently spec'd, it is an undefined behavior when an Expression that
evaluates to a Reference is present in a TemplateLiteral, as the
Reference value would be directly passed into ToString which expects an
ECMAScript language value.

Fixes tc39#935.
Verified
This commit was signed with a verified signature.
@TimothyGu TimothyGu Timothy Gu
GPG key ID: BC25111EF461A6F5 Learn about signing commits
8fc09e3

@TimothyGu TimothyGu referenced this issue Aug 30, 2018

Merged

Normative: Add missing GetValue() to TemplateLiteral evaluation #1298

TimothyGu added a commit to TimothyGu/ecma262 that referenced this issue Aug 30, 2018

@TimothyGu
Normative: Add missing GetValue() to TemplateLiteral evaluation 
As currently spec'd, it is an undefined behavior when an Expression that
evaluates to a Reference is present in a TemplateLiteral, as the
Reference value would be directly passed into ToString which expects an
ECMAScript language value.

Fixes tc39#935.
Verified
This commit was signed with a verified signature.
@TimothyGu TimothyGu Timothy Gu
GPG key ID: BC25111EF461A6F5 Learn about signing commits
cebb144

ljharb added a commit to TimothyGu/ecma262 that referenced this issue Sep 6, 2018

@TimothyGu @ljharb
Normative: Add missing GetValue() to TemplateLiteral evaluation 
As currently spec'd, it is an undefined behavior when an Expression that
evaluates to a Reference is present in a TemplateLiteral, as the
Reference value would be directly passed into ToString which expects an
ECMAScript language value.

Fixes tc39#935.
Verified
This commit was signed with a verified signature.
@ljharb ljharb Jordan Harband
GPG key ID: 64A196AEE0916D55 Learn about signing commits
44e8058

@ljharb ljharb closed this in #1298 Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment