/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a favicon #95

Closed
michaelficarra opened this Issue Oct 20, 2015 · 12 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@michaelficarra @domenic @jamiebuilds @allenwb @bterlson
@michaelficarra
Member

michaelficarra commented Oct 20, 2015

Now that the spec is distributed as a web page, it should have a favicon.
@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Oct 20, 2015

Member

How about this? ecma262-favicon
Member

michaelficarra commented Oct 20, 2015

How about this? ecma262-favicon
@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Oct 20, 2015

Member

What is that? A gas station?
Member

domenic commented Oct 20, 2015

What is that? A gas station?
@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Oct 20, 2015

Member

A mini version of the ECMA-262 title page:

ecma-262 title page
Member

michaelficarra commented Oct 20, 2015

A mini version of the ECMA-262 title page:

ecma-262 title page
@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Oct 20, 2015

Member

But that title page is not part of the spec anymore. Seems bad.

Just the usual ES logo makes sense to me.
Member

domenic commented Oct 20, 2015

But that title page is not part of the spec anymore. Seems bad.

Just the usual ES logo makes sense to me.
@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Oct 20, 2015

Member

You mean like this? 262 Boring.
Member

michaelficarra commented Oct 20, 2015

You mean like this? 262 Boring.
@jamiebuilds

This comment has been minimized.

Show comment
Hide comment
@jamiebuilds

jamiebuilds Oct 20, 2015

Member

@michaelficarra Do you like this one any better?

Member

jamiebuilds commented Oct 20, 2015

@michaelficarra Do you like this one any better?

@allenwb

This comment has been minimized.

Show comment
Hide comment
@allenwb

allenwb Oct 20, 2015

Member

Ecma owns the graphic design of Ecma publications and they already provide a favicon. You see it if you browser the official Ecma HTML distribution: http://ecma-international.org/ecma-262/6.0/

That favcon is available at https://github.com/tc39/ecma262-6-src/blob/master/es-spec-html/favicon.ico
Member

allenwb commented Oct 20, 2015

Ecma owns the graphic design of Ecma publications and they already provide a favicon. You see it if you browser the official Ecma HTML distribution: http://ecma-international.org/ecma-262/6.0/

That favcon is available at https://github.com/tc39/ecma262-6-src/blob/master/es-spec-html/favicon.ico
@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Oct 20, 2015

Member

Copying ES6 (ECMA) favicon here for posterity/convenience: ecma
Member

michaelficarra commented Oct 20, 2015

Copying ES6 (ECMA) favicon here for posterity/convenience: ecma
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Oct 20, 2015

Member

ahahahaha it is taking ALL my willpower not to install the favicon proposed by @thejameskyle. Will hopefully copy the one from es-spec-html, though.
Member

bterlson commented Oct 20, 2015

ahahahaha it is taking ALL my willpower not to install the favicon proposed by @thejameskyle. Will hopefully copy the one from es-spec-html, though.
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Oct 20, 2015

Member

Added the favicon to the gh-pages branch.
Member

bterlson commented Oct 20, 2015

Added the favicon to the gh-pages branch.

@bterlson bterlson closed this Oct 20, 2015

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Oct 20, 2015

Member

@bterlson Just adding the file to gh-pages isn't sufficient, as those files aren't served from the root. You'll have to add a <link> to the <head> that points to it. I'll submit a PR.

edit: See #96.
Member

michaelficarra commented Oct 20, 2015

@bterlson Just adding the file to gh-pages isn't sufficient, as those files aren't served from the root. You'll have to add a <link> to the <head> that points to it. I'll submit a PR.

edit: See #96.
@allenwb

This comment has been minimized.

Show comment
Hide comment
@allenwb

allenwb Oct 20, 2015

Member

Well, since it is just a draft and not the actual standard you could use a different favicon. That might even be preferable if it helps people distinguish drafts from the standard.
Member

allenwb commented Oct 20, 2015

Well, since it is just a draft and not the actual standard you could use a different favicon. That might even be preferable if it helps people distinguish drafts from the standard.

michaelficarra added a commit to michaelficarra/ecma262 that referenced this issue Oct 20, 2015

@michaelficarra
add link to favicon; ref tc39#95
9eb0d5a

michaelficarra added a commit to michaelficarra/ecma262 that referenced this issue Oct 20, 2015

@michaelficarra
add link to favicon; ref tc39#95
dd44fba

michaelficarra added a commit to michaelficarra/ecma262 that referenced this issue Oct 20, 2015

@michaelficarra
add link to favicon; ref tc39#95
0960401

bterlson added a commit that referenced this issue Oct 21, 2015

@michaelficarra @bterlson
Markup: Add link to favicon; ref #95
ecd34c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment