New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECMAScript 2017 HTML version - search broken, various 404s and script errors #959

Open
farsightsoftware opened this Issue Jul 26, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@farsightsoftware

farsightsoftware commented Jul 26, 2017

The search box in the HTML version of the latest released spec, http://www.ecma-international.org/ecma-262/8.0/index.html, is broken (typing something, say "class", doesn't find it). There are various 404s and script errors as you use the page.

Looks like a deployment issue on the ECMA site, these issues don't happen at https://tc39.github.io/ecma262/.

404s:

There's also an unexpected token error:

index.html:23 Uncaught SyntaxError: Unexpected token <

Presumably as a result of the 404s, mousing over various things causes errors like this:

index.html:685 Uncaught TypeError: Cannot read property
'prod-grammar-notation-StatementList' of undefined
    at Object.activateIfMouseOver (index.html:695)
    at HTMLDivElement.<anonymous> (index.html:501)
    at HTMLDivElement.<anonymous> (index.html:520)

(I posted this on es-discuss several days ago, but the suggestion was to open an issue here.)

@IgnoredAmbience

This comment has been minimized.

Show comment
Hide comment
@IgnoredAmbience

IgnoredAmbience Jul 26, 2017

Member

A couple of other issues:

  • An erroneous (and unclosed?) <script> tag has been inserted above the <title> tag.
  • The favicon URL is unstable, pointing to https://tc39.github.io/ecma262/2017/img/favicon.ico. The 2017 directory is likely to disappear when 2018 is progressed.
  • There's a few absolute links pointing to the draft standard, instead of being relative to the current document. (grep the html source for tc39.github.io/ecma262/#) (these seem to persist in the original source though, so I'll raise a PR as appropriate for this.)

The 404ing URLs appear to be referencing the directory created by a browser's "Save Page" functionality (complete with the © symbol from the page title).

Member

IgnoredAmbience commented Jul 26, 2017

A couple of other issues:

  • An erroneous (and unclosed?) <script> tag has been inserted above the <title> tag.
  • The favicon URL is unstable, pointing to https://tc39.github.io/ecma262/2017/img/favicon.ico. The 2017 directory is likely to disappear when 2018 is progressed.
  • There's a few absolute links pointing to the draft standard, instead of being relative to the current document. (grep the html source for tc39.github.io/ecma262/#) (these seem to persist in the original source though, so I'll raise a PR as appropriate for this.)

The 404ing URLs appear to be referencing the directory created by a browser's "Save Page" functionality (complete with the © symbol from the page title).

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Jul 27, 2017

Member

I will look in to this, thank you!

Member

bterlson commented Jul 27, 2017

I will look in to this, thank you!

@tjcrowder

This comment has been minimized.

Show comment
Hide comment
@tjcrowder

tjcrowder Sep 22, 2017

Bump. I refer people to the specification all the time. Would be better if it were working properly.

tjcrowder commented Sep 22, 2017

Bump. I refer people to the specification all the time. Would be better if it were working properly.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Sep 22, 2017

Member

Don't refer them to the outdated snapshot on that website. Refer them to the spec implemented by browsers at https://tc39.github.io/ecma262/ .

Member

domenic commented Sep 22, 2017

Don't refer them to the outdated snapshot on that website. Refer them to the spec implemented by browsers at https://tc39.github.io/ecma262/ .

@tjcrowder

This comment has been minimized.

Show comment
Hide comment
@tjcrowder

tjcrowder Sep 22, 2017

@domenic - Well, implemented by varying browsers at varying times. That's beside the point. The most recent snapshot should work properly.

tjcrowder commented Sep 22, 2017

@domenic - Well, implemented by varying browsers at varying times. That's beside the point. The most recent snapshot should work properly.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Sep 22, 2017

Member

No, ecma262 only includes things which have reached stage 4, and are implemented in multiple browsers.

The snapshot should generally not be referred to, especially by programmers.

Member

domenic commented Sep 22, 2017

No, ecma262 only includes things which have reached stage 4, and are implemented in multiple browsers.

The snapshot should generally not be referred to, especially by programmers.

@tjcrowder

This comment has been minimized.

Show comment
Hide comment
@tjcrowder

tjcrowder Sep 22, 2017

@domenic - Useful to know (where is that documented?). It's still beside the point. The snapshot should work properly, and it's perfectly valid to need to refer someone to how things were as of ES2017.

tjcrowder commented Sep 22, 2017

@domenic - Useful to know (where is that documented?). It's still beside the point. The snapshot should work properly, and it's perfectly valid to need to refer someone to how things were as of ES2017.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Sep 22, 2017

Member

I'll just leave it as "I disagree"; I think the less effort people spend on the snapshot, the better, so as to discourage people from referring to it. This is just my opinion, but I do think it'd be good to tone down your expectation that other people do work for you to fit your opinion.

Member

domenic commented Sep 22, 2017

I'll just leave it as "I disagree"; I think the less effort people spend on the snapshot, the better, so as to discourage people from referring to it. This is just my opinion, but I do think it'd be good to tone down your expectation that other people do work for you to fit your opinion.

@tjcrowder

This comment has been minimized.

Show comment
Hide comment
@tjcrowder

tjcrowder Sep 22, 2017

@domenic I don't deserve that slap. I've offered to help in the past and would happily help with this if it were something I could help with.

tjcrowder commented Sep 22, 2017

@domenic I don't deserve that slap. I've offered to help in the past and would happily help with this if it were something I could help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment