New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]Maybe some inaccurate descriptions in spec #967

Closed
NE-SmallTown opened this Issue Aug 5, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@NE-SmallTown

NE-SmallTown commented Aug 5, 2017

4.2 ECMAScript Overview says:

when the Writable attribute for a property is set to false

Why there "W" is capitals?

4.2.1 Objects

Unlike most class-based object languages

Shoud be "Unlike most class-based object-oriented languages"?

the ECMAScript language includes syntactic class definitions that permit programmers to concisely define objects

Should "objects" be "class"?

4.3.1 type

> set of data values as defined in clause 6 of this specification

I think the word "values" is confusing because here the title is "type" and the title of clause 6 is "Data Types and Values",so I think it would be better to replace the word "values" with "standard"/"specification" or "types".

Both 4.3.22Number object and 4.3.23Infinity and 4.3.24NaN

number value

Should "number" be "Number"?

The Syntactic Grammar

> The syntactic grammar as presented in clauses 12, 13, 14 and 15 is not a complete

Should "12, 13, 14 and 15 is" be "12, 13, 14, 15 and is"

5.2.5 Mathematical Operations

The notation “x modulo y” (y must be finite and nonzero) computes a value k of the same sign as y (or zero) such that abs(k) < abs(y) and x-k = q × y for some integer q.

  1. Should "of the same sign as y" be "of the same sign as x"?(e.g. -7%4 = -3, here x is -7, y is 4, and result -3 is same sign as -7(i.e. x))

  2. Should "NOTE floor(x) = x-(x modulo 1)." be "NOTE ceil(x) = x-(x modulo 1)."?(e.g. -1.5 - (-1.5%1) = -1, it is not floor(-1.5), it is ceil(-1.5))

Table 1: Well-known Symbols

"A Boolean valued property", "A function valued property", "A String valued property", "An object valued property"

Why the form of these are not consistent? i.e "A function valued property" -> "A Function valued property" and "An object valued property" -> "An Object valued property" or "A Boolean valued property" -> "A boolean valued property", "A String valued property" -> "A string valued property"

@NE-SmallTown NE-SmallTown changed the title from [Question]Some doubt in spec to [Question]Some doubts in spec Aug 5, 2017

@jmdyck

This comment has been minimized.

Show comment
Hide comment
@jmdyck

jmdyck Aug 7, 2017

Collaborator

4.2 ECMAScript Overview says:

when the Writable attribute for a property is set to false

Why there "W" is capitals?

Because this is referring to a specific attribute, whose name is spelled with a capital 'W'. But it should probably be written here as [[Writable]].

Collaborator

jmdyck commented Aug 7, 2017

4.2 ECMAScript Overview says:

when the Writable attribute for a property is set to false

Why there "W" is capitals?

Because this is referring to a specific attribute, whose name is spelled with a capital 'W'. But it should probably be written here as [[Writable]].

@jmdyck

This comment has been minimized.

Show comment
Hide comment
@jmdyck

jmdyck Aug 7, 2017

Collaborator

4.3.1 type

set of data values as defined in clause 6 of this specification

I think the word "values" is confusing because here the title is "type" and the title of clause 6 is "Data Types and Values",so I think it would be better to replace the word "values" with "standard"/"specification" or "types".

Clause 4.3 is "Terms and Definitions", so this clause is saying that a 'type' is a set of data values as defined in clause 6. Changing "values" to any of your other suggestions would result in an incorrect definition.

Collaborator

jmdyck commented Aug 7, 2017

4.3.1 type

set of data values as defined in clause 6 of this specification

I think the word "values" is confusing because here the title is "type" and the title of clause 6 is "Data Types and Values",so I think it would be better to replace the word "values" with "standard"/"specification" or "types".

Clause 4.3 is "Terms and Definitions", so this clause is saying that a 'type' is a set of data values as defined in clause 6. Changing "values" to any of your other suggestions would result in an incorrect definition.

@jmdyck

This comment has been minimized.

Show comment
Hide comment
@jmdyck

jmdyck Aug 7, 2017

Collaborator

The Syntactic Grammar

The syntactic grammar as presented in clauses 12, 13, 14 and 15 is not a complete

Should "12, 13, 14 and 15 is" be "12, 13, 14, 15 and is"

You're presumably missing something between "and" and "is".

Collaborator

jmdyck commented Aug 7, 2017

The Syntactic Grammar

The syntactic grammar as presented in clauses 12, 13, 14 and 15 is not a complete

Should "12, 13, 14 and 15 is" be "12, 13, 14, 15 and is"

You're presumably missing something between "and" and "is".

@NE-SmallTown NE-SmallTown changed the title from [Question]Some doubts in spec to [Question]Maybe some inaccurate descriptions in spec Aug 12, 2017

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Aug 18, 2017

cc @domenic @allenwb @littledan Do you have any thought about this? 😄

NE-SmallTown commented Aug 18, 2017

cc @domenic @allenwb @littledan Do you have any thought about this? 😄

@littledan

This comment has been minimized.

Show comment
Hide comment
@littledan

littledan Aug 18, 2017

Member

I don't see any of these as significant problems. For modulo, note that Applying the % operator does not reference the spec-internal modulo operation. Feel free to make a PR if you want to discuss casing in more detail, but I actually think each of these casing decisions are well-thought-out already and make sense.

Member

littledan commented Aug 18, 2017

I don't see any of these as significant problems. For modulo, note that Applying the % operator does not reference the spec-internal modulo operation. Feel free to make a PR if you want to discuss casing in more detail, but I actually think each of these casing decisions are well-thought-out already and make sense.

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown commented Aug 19, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment