Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upThe tree view on the side no longer works in Chrome #981
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
works for me. Maybe it's cache? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
isiahmeadows
commented
Aug 22, 2017
|
This was in a newly loaded incognito window, so it can't be that. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@isiahmeadows can you link to the version with the broken toc? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
isiahmeadows
Aug 23, 2017
Actually, it's just being super slow for me. Not "not working", just slow. I'll close this.
isiahmeadows
commented
Aug 23, 2017
|
Actually, it's just being super slow for me. Not "not working", just slow. I'll close this. |
isiahmeadows
closed this
Aug 23, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
isiahmeadows
Aug 23, 2017
By any chance, could Bikeshed be modified (semver major) to use JS to reduce the amount of data rendered to the DOM at a time? It's sequential enough it shouldn't be too hard to generate the JS, and it should help the rendering time of the HTML version by a lot.
(This is probably best suggested over there, but ¯\(ツ)/¯)
isiahmeadows
commented
Aug 23, 2017
|
By any chance, could Bikeshed be modified (semver major) to use JS to reduce the amount of data rendered to the DOM at a time? It's sequential enough it shouldn't be too hard to generate the JS, and it should help the rendering time of the HTML version by a lot. (This is probably best suggested over there, but ¯\(ツ)/¯) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Doing that would make "find in page" not work. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bterlson
Aug 23, 2017
Member
I have been looking into this some time, but it's a lot of work. It would break native "find in page" but you can implement the same functionality in JS. It can even be better than native (e.g. server-side find with caching can be much faster on a giant document).
|
I have been looking into this some time, but it's a lot of work. It would break native "find in page" but you can implement the same functionality in JS. It can even be better than native (e.g. server-side find with caching can be much faster on a giant document). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Whatever you do, please make sure it is still usable offline. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bterlson
Aug 24, 2017
Member
That's a negative. Taking a page from Allo, the spec is now a Web App that only works in Chrome.
|
That's a negative. Taking a page from Allo, the spec is now a Web App that only works in Chrome. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
domenic
Aug 24, 2017
Member
I forgot to say earlier, but I also would prefer not lazy-loading or overriding Ctrl+F or any other fancy tricks. The way the spec is now works great. It can be a bit slow to load, but that's OK; that's a fair price to pay compared to the drawbacks of lazy-rendering.
Some kind of secondary URL for a multipage or lazy-rendered version might make sense, like we do for HTML, but I'd like to keep the current architecture as the default. Actually, I'm OK with it even not being the default, as long as it's an option.
|
I forgot to say earlier, but I also would prefer not lazy-loading or overriding Ctrl+F or any other fancy tricks. The way the spec is now works great. It can be a bit slow to load, but that's OK; that's a fair price to pay compared to the drawbacks of lazy-rendering. Some kind of secondary URL for a multipage or lazy-rendered version might make sense, like we do for HTML, but I'd like to keep the current architecture as the default. Actually, I'm OK with it even not being the default, as long as it's an option. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bterlson
Aug 24, 2017
Member
Non-snark reply: certainly! Gh-pages will always just be a static rendering. My comment above is something for a different domain entirely.
|
Non-snark reply: certainly! Gh-pages will always just be a static rendering. My comment above is something for a different domain entirely. |
isiahmeadows commentedAug 22, 2017
Interestingly, this silently fails, without even a console error.