New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tree view on the side no longer works in Chrome #981

Closed
isiahmeadows opened this Issue Aug 22, 2017 · 11 comments

Comments

Projects
None yet
6 participants
@isiahmeadows

isiahmeadows commented Aug 22, 2017

Interestingly, this silently fails, without even a console error.

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Aug 22, 2017

Member

works for me. Maybe it's cache?

Member

leobalter commented Aug 22, 2017

works for me. Maybe it's cache?

@isiahmeadows

This comment has been minimized.

Show comment
Hide comment
@isiahmeadows

isiahmeadows Aug 22, 2017

This was in a newly loaded incognito window, so it can't be that.

isiahmeadows commented Aug 22, 2017

This was in a newly loaded incognito window, so it can't be that.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Aug 22, 2017

Member

@isiahmeadows can you link to the version with the broken toc?

Member

bterlson commented Aug 22, 2017

@isiahmeadows can you link to the version with the broken toc?

@isiahmeadows

This comment has been minimized.

Show comment
Hide comment
@isiahmeadows

isiahmeadows Aug 23, 2017

Actually, it's just being super slow for me. Not "not working", just slow. I'll close this.

isiahmeadows commented Aug 23, 2017

Actually, it's just being super slow for me. Not "not working", just slow. I'll close this.

@isiahmeadows

This comment has been minimized.

Show comment
Hide comment
@isiahmeadows

isiahmeadows Aug 23, 2017

By any chance, could Bikeshed be modified (semver major) to use JS to reduce the amount of data rendered to the DOM at a time? It's sequential enough it shouldn't be too hard to generate the JS, and it should help the rendering time of the HTML version by a lot.

(This is probably best suggested over there, but ¯\(ツ)/¯)

isiahmeadows commented Aug 23, 2017

By any chance, could Bikeshed be modified (semver major) to use JS to reduce the amount of data rendered to the DOM at a time? It's sequential enough it shouldn't be too hard to generate the JS, and it should help the rendering time of the HTML version by a lot.

(This is probably best suggested over there, but ¯\(ツ)/¯)

@ljharb

This comment has been minimized.

Show comment
Hide comment
@ljharb

ljharb Aug 23, 2017

Member

Doing that would make "find in page" not work.

Member

ljharb commented Aug 23, 2017

Doing that would make "find in page" not work.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Aug 23, 2017

Member

I have been looking into this some time, but it's a lot of work. It would break native "find in page" but you can implement the same functionality in JS. It can even be better than native (e.g. server-side find with caching can be much faster on a giant document).

Member

bterlson commented Aug 23, 2017

I have been looking into this some time, but it's a lot of work. It would break native "find in page" but you can implement the same functionality in JS. It can even be better than native (e.g. server-side find with caching can be much faster on a giant document).

@allenwb

This comment has been minimized.

Show comment
Hide comment
@allenwb

allenwb Aug 23, 2017

Member

Whatever you do, please make sure it is still usable offline.

Member

allenwb commented Aug 23, 2017

Whatever you do, please make sure it is still usable offline.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Aug 24, 2017

Member

That's a negative. Taking a page from Allo, the spec is now a Web App that only works in Chrome.

Member

bterlson commented Aug 24, 2017

That's a negative. Taking a page from Allo, the spec is now a Web App that only works in Chrome.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Aug 24, 2017

Member

I forgot to say earlier, but I also would prefer not lazy-loading or overriding Ctrl+F or any other fancy tricks. The way the spec is now works great. It can be a bit slow to load, but that's OK; that's a fair price to pay compared to the drawbacks of lazy-rendering.

Some kind of secondary URL for a multipage or lazy-rendered version might make sense, like we do for HTML, but I'd like to keep the current architecture as the default. Actually, I'm OK with it even not being the default, as long as it's an option.

Member

domenic commented Aug 24, 2017

I forgot to say earlier, but I also would prefer not lazy-loading or overriding Ctrl+F or any other fancy tricks. The way the spec is now works great. It can be a bit slow to load, but that's OK; that's a fair price to pay compared to the drawbacks of lazy-rendering.

Some kind of secondary URL for a multipage or lazy-rendered version might make sense, like we do for HTML, but I'd like to keep the current architecture as the default. Actually, I'm OK with it even not being the default, as long as it's an option.

@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Aug 24, 2017

Member

Non-snark reply: certainly! Gh-pages will always just be a static rendering. My comment above is something for a different domain entirely.

Member

bterlson commented Aug 24, 2017

Non-snark reply: certainly! Gh-pages will always just be a static rendering. My comment above is something for a different domain entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment