Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: replace obj.[[Get]](j) with Get(obj, j) #1183

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@mysticatea
Copy link
Contributor

mysticatea commented Apr 23, 2018

Fixes #1180.

This PR replaces those obj.[[Get]](j)s by the abstract operation Get(obj, j) since those lacked the 2nd argument Receiver.

@ljharb
ljharb approved these changes Apr 23, 2018
@ljharb ljharb requested review from bterlson, bmeck and allenwb Apr 23, 2018
Copy link
Member

allenwb left a comment

This change seems fine (the old text predates the existance of the receiver argument to [[Get]]).

But shouldn't all other reference to [[Get]] within this subclause also be replaced. And, all references to [[Set]] replaced with Set.

@bterlson

This comment has been minimized.

Copy link
Member

bterlson commented May 1, 2018

Agree with @allenwb for step 1 of the preceding algorithm - [[Get]] and [[Set]] should be replaced by Get and Set. However I think the bullet points for when sort order is implementation defined are ok since it's describing an object's slots not any particular operation involving them?

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jan 26, 2019

@mysticatea can you update this PR?

@ljharb ljharb requested review from zenparsing and tc39/ecma262-editors and removed request for bterlson Feb 28, 2019
@ljharb ljharb removed request for bmeck and zenparsing Oct 4, 2019
@mysticatea

This comment has been minimized.

Copy link
Contributor Author

mysticatea commented Oct 7, 2019

Hi. I apologize that I have lost on this in my busy life.

Thank you for your review. I have updated this PR.

  • d5f0a7d I updated "[[Get]] internal method" and "[[Set]] internal method" to "Get abstract operation" and "Set abstract operation".
  • 92afd16 Because the Set abstract operation has the functionality that throws TypeError if the [[Set]] internal method returned false, I updated to use it.
  • 31df05a Because the auto linker doesn't link Set words which are not followed by (, I enclosed the Set words by <emu-xref> tag.
@ljharb ljharb requested review from allenwb and mathiasbynens Oct 8, 2019
@bakkot bakkot added the editor call label Nov 6, 2019
@ljharb ljharb requested review from michaelficarra, syg and bakkot Nov 20, 2019
@ljharb ljharb self-assigned this Nov 27, 2019
Fixes #1180.

 - replace [[Get]] and [[Set]] internal methods by Get and Set abstract operations
 - update about TypeError in Set abstract operation
 - make link to Set
@ljharb ljharb force-pushed the mysticatea:issue1180 branch from 31df05a to 618479a Nov 27, 2019
@bakkot
bakkot approved these changes Nov 27, 2019
@syg
syg approved these changes Nov 27, 2019
@ljharb ljharb merged commit 618479a into tc39:master Nov 27, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@mysticatea mysticatea deleted the mysticatea:issue1180 branch Nov 28, 2019
sthagen added a commit to sthagen/ecma262 that referenced this pull request Nov 28, 2019
Editorial: replace obj.[[Get]](j) with Get(obj, j) (tc39#1183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.