New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix formatting of grammar productions ending in html entities #1381

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@NilSet
Copy link
Contributor

NilSet commented Dec 27, 2018

A bug in grammarkdown (which is fixed in master and not yet released)
causes a newline after an html entity to get consumed, making
alternatives run together and look like a seqence of symbols.

This commit works around the bug by adding a trailing space after html
entities in grammar productions.

See rbuckton/grammarkdown#29 for the proper fix
which has yet to be released.

@ljharb ljharb changed the title Editorial: Fix formatting of grammar productions ending in html entiies Editorial: Fix formatting of grammar productions ending in html entities Dec 27, 2018

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Dec 27, 2018

This looks fine, but it seems perhaps like we should ping @rbuckton for a release so we can get the benefit without the workaround?

@rbuckton

This comment has been minimized.

Copy link
Contributor

rbuckton commented Dec 28, 2018

grammarkdown@2.0.12 has been published on npm with the fix mentioned above.

@NilSet

This comment has been minimized.

Copy link
Contributor

NilSet commented Dec 28, 2018

Given that the package-lock.json is gitignored, @rbuckton 's update should be picked up by the next build of https://tc39.github.io/ecma262

@NilSet NilSet closed this Dec 28, 2018

Meta: update @alrra/travis-scripts
(also forces a rebuild; per #1381)
@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jan 2, 2019

(I'll repurpose this to force the dep update and the rebuild)

@ljharb ljharb reopened this Jan 2, 2019

@ljharb ljharb force-pushed the NilSet:workaround-entities-rendering branch from e765236 to 85ce767 Jan 2, 2019

@ljharb ljharb merged commit 85ce767 into tc39:master Jan 2, 2019

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@NilSet

This comment has been minimized.

Copy link
Contributor

NilSet commented Jan 2, 2019

This fixed #1336 #1334 #1304 and #1222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment