Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Editorial: correctly determine flags for static RegExp parsing #1464
Fixes #1343 according to the approach discussed therein; see that issue for full context, but briefly, the current spec text says to do a parse according to "the goal symbol Pattern", which is meaningless in the current spec because Pattern has flags, which must be provided. Determining these flags is a little involved.
As it says there, this is heavily duplicated with the runtime semantics for RegExpInitialize. If the editors think this is worth noting, or avoiding, I can try to come up with something.
ljharb left a comment
This seems good to me (pending requested reviews), but it does seem good to maybe create a separate abstract operation