Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Grammar "so has the features..." -> "so have the features..." #1471

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Tomy8s
Copy link

Tomy8s commented Mar 7, 2019

Small grammar mistake:

If we consider we are discussing "the features and facities ECMAScript provides",

It would be grammatically incorrect to write:

As the usage of ECMAScript has expanded, so has they.

And also grammatically incorrect to write:

As the usage of ECMAScript has expanded, so has the features and facilities it provides.


It would be grammatically correct to write:

As the usage of ECMAScript has expanded, so have they.

And therefore would be grammatically correct for spec.html to read:

As the usage of ECMAScript has expanded, so have the features and facilities it provides.

@rkirsling

This comment has been minimized.

Copy link
Member

rkirsling commented Mar 7, 2019

Nice catch!

I suppose it's easy to overlook because one sort of wants it to be balanced as has/has. 🤔
Toward that end, we could alternatively make the subordinate subject singular:

As the usage of ECMAScript has expanded, so has the breadth of the features and facilities it provides.

@ljharb

ljharb approved these changes Mar 7, 2019

Copy link
Member

ljharb left a comment

Thanks, this LGTM. Suggested a tweak.

@@ -138,7 +138,7 @@ <h1>Overview</h1>
<p>ECMAScript is an object-oriented programming language for performing computations and manipulating computational objects within a host environment. ECMAScript as defined here is not intended to be computationally self-sufficient; indeed, there are no provisions in this specification for input of external data or output of computed results. Instead, it is expected that the computational environment of an ECMAScript program will provide not only the objects and other facilities described in this specification but also certain environment-specific objects, whose description and behaviour are beyond the scope of this specification except to indicate that they may provide certain properties that can be accessed and certain functions that can be called from an ECMAScript program.</p>
<p>ECMAScript was originally designed to be used as a scripting language, but has become widely used as a general-purpose programming language. A <em>scripting language</em> is a programming language that is used to manipulate, customize, and automate the facilities of an existing system. In such systems, useful functionality is already available through a user interface, and the scripting language is a mechanism for exposing that functionality to program control. In this way, the existing system is said to provide a host environment of objects and facilities, which completes the capabilities of the scripting language. A scripting language is intended for use by both professional and non-professional programmers.</p>
<p>ECMAScript was originally designed to be a <em>Web scripting language</em>, providing a mechanism to enliven Web pages in browsers and to perform server computation as part of a Web-based client-server architecture. ECMAScript is now used to provide core scripting capabilities for a variety of host environments. Therefore the core language is specified in this document apart from any particular host environment.</p>
<p>ECMAScript usage has moved beyond simple scripting and it is now used for the full spectrum of programming tasks in many different environments and scales. As the usage of ECMAScript has expanded, so has the features and facilities it provides. ECMAScript is now a fully featured general-purpose programming language.</p>
<p>ECMAScript usage has moved beyond simple scripting and it is now used for the full spectrum of programming tasks in many different environments and scales. As the usage of ECMAScript has expanded, so have the features and facilities it provides. ECMAScript is now a fully featured general-purpose programming language.</p>

This comment has been minimized.

@ljharb

ljharb Mar 7, 2019

Member
Suggested change
<p>ECMAScript usage has moved beyond simple scripting and it is now used for the full spectrum of programming tasks in many different environments and scales. As the usage of ECMAScript has expanded, so have the features and facilities it provides. ECMAScript is now a fully featured general-purpose programming language.</p>
<p>ECMAScript usage has moved beyond simple scripting and it is now used for the full spectrum of programming tasks in many different environments and at many scales. As the usage of ECMAScript has expanded, so have the features and facilities it provides. ECMAScript is now a fully featured general-purpose programming language.</p>

@ljharb ljharb requested review from zenparsing and tc39/ecma262-editors Mar 7, 2019

@ljharb ljharb self-assigned this Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.