Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Editorial #1509

Merged
merged 4 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@jmdyck
Copy link
Collaborator

commented Apr 13, 2019

14 commits re a bunch of merges 3 days ago.

@ljharb ljharb requested review from ljharb, zenparsing and tc39/ecma262-editors Apr 13, 2019

@ljharb

This comment was marked as resolved.

Copy link
Member

commented Apr 13, 2019

@jmdyck it’d be great if you could collapse all the matchAll fixes into a single commit (my bad on those). Thanks!

@jmdyck

This comment was marked as resolved.

Copy link
Collaborator Author

commented Apr 13, 2019

Including the ones relating to RegExp String Iterator?

@ljharb

This comment was marked as resolved.

Copy link
Member

commented Apr 13, 2019

Yes, ideally - i’m happy to do it for you if it’s a burden ofc, but I’m hoping to have one single errata commit for #1480 :-)

@jmdyck

This comment was marked as resolved.

Copy link
Collaborator Author

commented Apr 13, 2019

I should be able to do that.

@jmdyck jmdyck force-pushed the jmdyck:editorial branch from 52b5a7c to dcc4746 Apr 13, 2019

@jmdyck

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 13, 2019

Done: squashed 11 commits into one. (This PR now has just 4 commits.)

@jmdyck jmdyck force-pushed the jmdyck:editorial branch 2 times, most recently from 5e117fa to 506c22d Apr 24, 2019

@ljharb

ljharb approved these changes May 2, 2019

@ljharb ljharb self-assigned this May 2, 2019

jmdyck added some commits Apr 11, 2019

Editorial: Various tweaks re String.prototype.matchAll (#1509)
These edits all relate to commit 71927e1 from PR #1480.

- Markup: repair a malformed <emu-xref> tag

- Editorial: Append "then" to "If" steps

- Markup: change hyphens to dots in clause-id for String.prototype.matchAll

- Editorial: Change RIGHT SINGLE QUOTATION MARK to APOSTROPHE
  (U+2019 to U+0027)

- Markup: Remove underscores from "_CreateRegExpStringIterator_"
  ... because it's not a variable.

- Editorial: dissolve 2 <emu-xref> elements
  ... that should be handled by ecmarkup's auto-linking.

- Markup: Use conventional format for clause-ids
  (for clauses relating to RegExp String Iterator Object + Instances)

- Editorial: Define %RegExpStringIteratorPrototype% like other intrinsics

- Editorial: Insert space before square-bracket
  ... in "%RegExpStringIteratorPrototype% [ @@toStringTag ]"

- Editorial: Hoist "Properties of RegExp String Iterator Instances" clause
  Move it 'up' one level
  (pop it out of "The %RegExpStringIteratorPrototype% Object" clause),
  because it's not defining a property of %RegExpStringIteratorPrototype%.

- Markup: Tweak "Internal Slots of RegExp String Iterator Instances" table.
  Change <figure>/<figurecaption>/<span> to <emu-table>.
  Change the id from "table-1" to something more mnemonic.
  Delete spurious "<tr>" tag.
  Refer to it with an <emu-xref> rather than an <a> element.

(Originally, these were 11 separate commits,
but @ljharb requested that I collapse them.)

@ljharb ljharb force-pushed the jmdyck:editorial branch from 506c22d to 5c93a68 May 2, 2019

@ljharb ljharb merged commit 5c93a68 into tc39:master May 2, 2019

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.