Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Use IsCallable abstract op #1529

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@shvaikalesh
Copy link
Contributor

commented May 8, 2019

No description provided.

@ljharb ljharb requested review from ljharb, zenparsing and tc39/ecma262-editors May 8, 2019

@ljharb

ljharb approved these changes May 8, 2019

Show resolved Hide resolved spec.html

@shvaikalesh shvaikalesh force-pushed the shvaikalesh:is-callable branch from e053a6a to 16af531 May 8, 2019

@shvaikalesh

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Apart from IsCallable (55 references), there are couple more abstract ops that always return normal completion and are implicitly unpacked:

I agree that explicitly unwrapping these operations benefits readability: there are a few Is* helpers that yield abrupt completions (IsArray, IsExtensible, IsRegExp), so a reader can't really tell by name.

Is PR welcome?

@ljharb

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Yes, a separate PR for that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.