Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc editorial #1566

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
4 participants
@jmdyck
Copy link
Collaborator

commented Jun 2, 2019

No description provided.

Show resolved Hide resolved spec.html Outdated
@ljharb

ljharb approved these changes Jun 2, 2019

@ljharb ljharb requested review from zenparsing and tc39/ecma262-editors Jun 2, 2019

@jmdyck jmdyck force-pushed the jmdyck:editorial branch from 7b71e45 to c67c939 Jun 11, 2019

@jmdyck jmdyck changed the title Editorial: Insert "is *true*" Misc editorial Jun 11, 2019

@jmdyck

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 11, 2019

Added another tweak.

@jmdyck

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 12, 2019

Added 9 more commits.

@jmdyck

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 13, 2019

And one more.

@jmdyck jmdyck force-pushed the jmdyck:editorial branch from 6087ae5 to 626dc2a Jun 17, 2019

@jmdyck

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 17, 2019

(force-pushed to resolve merge conflicts)

@ljharb ljharb self-assigned this Jun 17, 2019

Editorial: consistent spacing/commas/wording/encoding/ecmarkup (#1566)
 - Insert "is *true*"
 - Delete extra spaces
 - Before "else", change comma to semicolon (which is 4x more frequent)
 - After "else", delete comma
 - "Push X on to" -> "Push X onto" (3x former, 13x latter)
 - Insert comma after "Otherwise"
   When "Otherwise" occurs at the start of a step, the consensus is to follow it with a comma
   (When it occurs in the middle of a step, usage is split)
 - After "neither", change "or" to "nor"
 - Insert space between "</emu-grammar>" and "." to make the 'D' case consistent with 'S' and 'W'
 - Change non-ASCII character to character reference
 - Use <emu-xref>'s 'title' attribute to simplify 3 cross-references
 - Delete "when evaluated" from phrases of the form:
     an internal ... closure that ... performs the following steps when evaluated:
   The spec already has lots of examples without the "when evaluated", so it doesn't seem to be necessary.
 - Eliminate some forms of record-constructor. Formerly, we had four forms of 'record constructor':
        a <Record Name> { ... }
    a new <Record Name> { ... }
      the <Record Name> { ... }
          <Record Name> { ... }
   Change all occurrences of the first two into the third.
 - Change "th" to "<sup>th</sup>" when it's applied to an alias.
    For consistency, and also to make it easier to find all aliases
    (because now the closing '_' is always a word boundary).

@ljharb ljharb force-pushed the jmdyck:editorial branch from 626dc2a to b8003a5 Jun 17, 2019

@ljharb ljharb merged commit b8003a5 into tc39:master Jun 17, 2019

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jmdyck

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.