Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

set [[SourceText]] in NamedEvaluation of ClassExpression #1569

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@michaelficarra
Copy link
Member

commented Jun 4, 2019

In #1560, we discovered that deferring NamedEvaluation to the evaluation algorithm for ClassExpressions would cause an undesirable change in behaviour. So this PR is the alternative: keep NamedEvaluation of ClassExpression special and set its [[SourceText]] slot.

This should be the last missing [[SourceText]] slot 馃.

@ljharb

ljharb approved these changes Jun 4, 2019

@ljharb ljharb requested review from zenparsing and tc39/ecma262-editors Jun 4, 2019

@jmdyck

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

@anba has this change in the first commit of #1490.

@ljharb

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

That's a larger PR, so it'd be good to land this first :-)

@jmdyck

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

Okay, wasn't sure about protocol.

@jmdyck

jmdyck approved these changes Jun 4, 2019

Copy link
Collaborator

left a comment

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.