Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: IsSimpleParameterList is false for standalone rest parameters #1608

Conversation

@gibson042
Copy link
Contributor

gibson042 commented Jul 2, 2019

I noticed in passing that this case was missing.

@ljharb

This comment was marked as resolved.

Copy link
Member

ljharb commented Jul 2, 2019

hm, need this be non simple tho? iow does it create the strict/sloppy parsing difficulties that led to this check?

@devsnek

This comment has been minimized.

Copy link
Member

devsnek commented Jul 2, 2019

all the engines throw a syntax error for it (except xs, known bug) 🤷‍♂

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jul 3, 2019

Technically i think this is normative.

@gibson042

This comment has been minimized.

Copy link
Contributor Author

gibson042 commented Jul 3, 2019

I wondered about that, but settled on editorial with the presumption that the behavior was understood to be expected but just hadn't been correctly represented in spec text.

@jmdyck

This comment has been minimized.

Copy link
Collaborator

jmdyck commented Jul 3, 2019

I plugged this hole in this commit of PR #1301.

(And I decided it was editorial too.)

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jul 3, 2019

I'd consider it a normative spec bug; imo editorial is exclusively for things that aren't observable.

@gibson042 gibson042 changed the title Editorial: IsSimpleParameterList is false for standalone rest parameters Normative: IsSimpleParameterList is false for standalone rest parameters Jul 3, 2019
@anba

This comment has been minimized.

Copy link
Collaborator

anba commented Jul 19, 2019

FWIW this is a regression from 6a06509

@ljharb ljharb requested review from zenparsing, ljharb, jeffmo and tc39/ecma262-editors Jul 19, 2019
@ljharb ljharb requested review from waldemarhorwat and devsnek and removed request for zenparsing Sep 30, 2019
@ljharb ljharb requested a review from syg Oct 18, 2019
ljharb added a commit to gibson042/ecma262 that referenced this pull request Nov 9, 2019
…ers (tc39#1608)
@ljharb ljharb force-pushed the gibson042:2019-07-IsSimpleParameterList-FunctionRestParameter branch from e0b9ea5 to 4e75c78 Nov 9, 2019
@ljharb ljharb requested a review from bakkot Nov 18, 2019
@bakkot
bakkot approved these changes Nov 18, 2019
@ljharb
ljharb approved these changes Nov 18, 2019
…ers (#1608)
@ljharb ljharb force-pushed the gibson042:2019-07-IsSimpleParameterList-FunctionRestParameter branch from 4e75c78 to 19e88da Nov 18, 2019
@ljharb ljharb merged commit 19e88da into tc39:master Nov 18, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.