Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Reference DecimalDigit rather than duplicating its RHS #1728

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@gibson042
Copy link
Contributor

commented Oct 8, 2019

Simple improvement noticed while working on #1727.

@ljharb ljharb requested a review from tc39/ecma262-editors Oct 8, 2019
@ljharb
ljharb approved these changes Oct 8, 2019
@ljharb

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

@gibson042 is it also worth collapsing more things, so that DecimalDigit is composed of OctalDigit and 8 and 9; and HexDigit is composed of DecimalDigit and a-F; and perhaps OctalDigit is composed of ZeroToThree and FourToSeven?

ljharb added a commit to gibson042/ecma262 that referenced this pull request Oct 8, 2019
@ljharb ljharb force-pushed the gibson042:2019-10-consolidate-decimal-digits branch from 7447fb7 to 74625ec Oct 8, 2019
@gibson042

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

I'd be open to that, but I do think there's value in each of the "Digit" productions having a complete and independent enumeration.

@ljharb ljharb self-assigned this Oct 9, 2019
)
@ljharb ljharb force-pushed the gibson042:2019-10-consolidate-decimal-digits branch from 74625ec to 068f7a6 Oct 9, 2019
@ljharb ljharb merged commit 068f7a6 into tc39:master Oct 9, 2019
1 check passed
1 check passed
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.