Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] use an HTML comment to avoid auto-dfn-linking #1731

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@ljharb
Copy link
Member

commented Oct 9, 2019

Fixes #1730

Fixes #1730
@ljharb ljharb added the meta label Oct 9, 2019
@ljharb ljharb requested review from michaelficarra and jmdyck Oct 9, 2019
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 9, 2019
Fixes tc39#1730
@ljharb ljharb force-pushed the ljharb:auto-link branch from 05ee600 to 8c68d03 Oct 9, 2019
spec.html Show resolved Hide resolved
Copy link
Collaborator

left a comment

It seems like it would be preferable to modify ecmarkup to either:

  • not auto-link the contents of <div id=metadata-block>, or
  • support a less hacky way to spot-disable auto-linking (e.g.: <span class="do-not-autolink">Mailing List Archives</span>)

On the other hand, I can see that this hack is less work. (Assuming there aren't many similar cases.)

Of the two versions, the embedded-comment version is at least explanatory.

@ljharb

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

@jmdyck i totally agree on both bullet points (it'd be great if you filed ecmarkup issues :-D ) but for now this seems expedient.

ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 9, 2019
Fixes tc39#1730
@ljharb ljharb force-pushed the ljharb:auto-link branch from 8c68d03 to 683d2e2 Oct 9, 2019
@ljharb ljharb requested a review from bakkot Oct 9, 2019
@bakkot
bakkot approved these changes Oct 9, 2019
@ljharb ljharb changed the title [meta] use a zero-width space to avoid auto-dfn-linking [meta] use an HTML comment to avoid auto-dfn-linking Oct 9, 2019
@ljharb ljharb force-pushed the ljharb:auto-link branch from 683d2e2 to f7a1365 Oct 9, 2019
@ljharb ljharb merged commit f7a1365 into tc39:master Oct 9, 2019
1 check passed
1 check passed
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@ljharb ljharb deleted the ljharb:auto-link branch Oct 9, 2019
@jmdyck jmdyck referenced this pull request Oct 11, 2019
@jmdyck

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2019

(it'd be great if you filed ecmarkup issues :-D )

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.