Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add BigInt to the list of primitive values #1769

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Nov 2, 2019

BigInt is missing in the list of primitive values

Copy link
Contributor

syg left a comment

Thanks for catching this. It'd be nice to update the "A primitive value is..." sentence in 4.2, as well as add "BigInt type" and "BigInt object" to the list of definitions in 4.3

@syg
syg approved these changes Nov 2, 2019
Copy link
Contributor

syg left a comment

lgtm. Thanks!

@ljharb ljharb requested review from tc39/ecma262-editors, michaelficarra and bakkot Nov 2, 2019
@ljharb
ljharb approved these changes Nov 2, 2019
Copy link
Member

ljharb left a comment

Thanks, good catch!

@ljharb ljharb self-assigned this Nov 2, 2019
spec.html Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb requested a review from bakkot Nov 5, 2019
@bakkot
bakkot approved these changes Nov 5, 2019
@ljharb ljharb force-pushed the chicoxyzzy:bigint_as_primitive_value branch from d36231c to d1b6707 Nov 8, 2019
@ljharb ljharb merged commit d1b6707 into tc39:master Nov 8, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@chicoxyzzy chicoxyzzy deleted the chicoxyzzy:bigint_as_primitive_value branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.