Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Make super() throw after evaluating args #1775

Open
wants to merge 1 commit into
base: master
from

Conversation

@bmeck
Copy link
Member

bmeck commented Nov 12, 2019

fixes #1351

@bmeck bmeck requested a review from bakkot Nov 12, 2019
@bakkot
bakkot approved these changes Nov 12, 2019
Copy link
Member

jridgewell left a comment

Because the GitHub diff is super unclear for files this large, it's moving the IsConstructor call from GetSuperConstructor abstract op (which runs before arg evaluation) to SuperCall : super Arguments evaluation (after the arg evaluation).

@ljharb ljharb requested review from syg, michaelficarra and tc39/ecma262-editors Nov 12, 2019
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@ljharb
ljharb approved these changes Nov 12, 2019
@ljharb ljharb self-assigned this Nov 12, 2019
ljharb added a commit to bmeck/ecma262 that referenced this pull request Nov 12, 2019
Fixes tc39#1351.
@ljharb ljharb force-pushed the bmeck:get-super-after-args branch from 9d46c3b to 596a61f Nov 12, 2019
@ljharb ljharb added has consensus and removed needs consensus labels Dec 3, 2019
@bmeck bmeck force-pushed the bmeck:get-super-after-args branch from 596a61f to 9d46c3b Dec 6, 2019
@bmeck

This comment has been minimized.

Copy link
Member Author

bmeck commented Dec 6, 2019

this has been rebased.

@ljharb ljharb force-pushed the bmeck:get-super-after-args branch from 9d46c3b to 79dd331 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.