Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Add missing `ReturnIfAbrupt` to “Evaluation of `in` expression” #1826

Merged
merged 1 commit into from Jan 11, 2020

Conversation

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Jan 3, 2020

Fixes #1806

@ljharb ljharb requested review from syg, michaelficarra, bakkot and tc39/ecma262-editors Jan 3, 2020
@ljharb
ljharb approved these changes Jan 3, 2020
Copy link
Member

ljharb left a comment

Thanks!

@syg
syg approved these changes Jan 10, 2020
…sion” (#1826)
@ljharb ljharb changed the title fix: Add missing `ReturnIfAbrupt` to “Evaluation of `in` expression” Normative: Add missing `ReturnIfAbrupt` to “Evaluation of `in` expression” Jan 10, 2020
@ljharb

This comment was marked as resolved.

Copy link
Member

ljharb commented Jan 10, 2020

@ExE-Boss i'm afraid that your use of "EB-Forks" instead of forking from your personal profile means i'm unable to force push to your PR branch. Mind if we do the same permissions fix as in other repos as a workaround?

@ljharb ljharb self-assigned this Jan 10, 2020
@ljharb

This comment was marked as resolved.

Copy link
Member

ljharb commented Jan 10, 2020

@ExE-Boss i got the team invite, but this repo's fork still isn't in the list :-)

@ExE-Boss

This comment was marked as resolved.

Copy link
Contributor Author

ExE-Boss commented Jan 11, 2020

@ljharb I’ve now added all currently forked @tc39 repositories to the list.

GitHub should seriously fix “Allow edits from maintainers.” when it’s used with forks located in organisations.

@ljharb ljharb force-pushed the EB-Forks:fix/issue-1806 branch from 6876b84 to 73ad599 Jan 11, 2020
@ljharb

This comment was marked as resolved.

Copy link
Member

ljharb commented Jan 11, 2020

@ExE-Boss it looks like you may not have yet registered as a contributor. Can you fill out the form here?

@ljharb ljharb closed this Jan 11, 2020
@ljharb ljharb reopened this Jan 11, 2020
@ljharb ljharb merged commit 73ad599 into tc39:master Jan 11, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@ljharb ljharb deleted the EB-Forks:fix/issue-1806 branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.