Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Fix the LexicalEnvironment of the execution context during function parameter eval #1829

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@syg
Copy link
Contributor

syg commented Jan 3, 2020

Fallout from #1046. When creating a new environment so that
sloppy direct eval-introduced vars are in a different environment, the
LexicalEnvironment of the execution context was not updated.

Thanks to @devsnek for the catch.

@syg syg added the spec bug label Jan 3, 2020
@syg syg requested a review from ljharb Jan 3, 2020
@devsnek
devsnek approved these changes Jan 3, 2020
@ljharb ljharb requested review from michaelficarra, bakkot and tc39/ecma262-editors Jan 3, 2020
… function parameter evaluation (#1829)

Fallout from #1046. When creating a new environment so that
sloppy direct eval-introduced vars are in a different environment, the
LexicalEnvironment of the execution context was not updated.
@ljharb ljharb force-pushed the syg:fix-fdi branch from ac14ce9 to f0c10cf Jan 3, 2020
@ljharb
ljharb approved these changes Jan 3, 2020
@ljharb ljharb merged commit f0c10cf into tc39:master Jan 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@ljharb ljharb changed the title Bugfix: Fix the LexicalEnvironment of the execution context during function parameter eval Normative: Fix the LexicalEnvironment of the execution context during function parameter eval Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.