Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Stop letting ecmarkup load 262's own outdated bibliography file. #1839

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@rkirsling
Copy link
Member

rkirsling commented Jan 10, 2020

Problem

Links to abstract operations thisBooleanValue and thisTimeValue are absolute and point to https://tc39.github.io/ecma262.

Cause

And so, ecmarkup thinks living ECMA-262 is just some spec that happens to reference ES2017.

Solution

  1. Ensure es6biblio.json is an empty object before building 262 (this PR).
  2. Update es6biblio.json over in ecmarkup, since everybody else needs it (PR bterlson/ecmarkup#167).
  3. Have ecmarkup allow 262 to opt out of loading es6biblio.json (issue bterlson/ecmarkup#168).
@ljharb ljharb requested a review from tc39/ecma262-editors Jan 10, 2020
@ljharb
ljharb approved these changes Jan 10, 2020
Copy link
Member

ljharb left a comment

Verified via the preview that this workaround fixes the issue. Thanks!

@ljharb ljharb force-pushed the rkirsling:dont-load-own-biblio branch from add884a to a329eef Jan 10, 2020
@ljharb ljharb merged commit a329eef into tc39:master Jan 10, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@rkirsling rkirsling deleted the rkirsling:dont-load-own-biblio branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.