Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: make callers of SV consistent #1862

Merged
merged 1 commit into from Feb 19, 2020
Merged

Editorial: make callers of SV consistent #1862

merged 1 commit into from Feb 19, 2020

Conversation

@bakkot
Copy link
Contributor

bakkot commented Feb 1, 2020

Static Semantics: SV gives definitions for the SVs of the various parts of string literals.

This PR changes the four callers of this abstract operation which are phrased as SV(|Foo|) to be phrased as the SV of |Foo| instead, to match all other callers.

(Also two of these calls are not valid, but that can be fixed separately. See #1861.)

@ljharb ljharb requested review from syg, tc39/ecma262-editors and michaelficarra Feb 1, 2020
@ljharb
ljharb approved these changes Feb 1, 2020
@ljharb ljharb self-assigned this Feb 4, 2020
@syg
syg approved these changes Feb 19, 2020
@ljharb ljharb force-pushed the sv-calling-convention branch from 51ff821 to ab30b81 Feb 19, 2020
@ljharb ljharb merged commit ab30b81 into master Feb 19, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ecma262-snapshots/deploy-preview Deploy preview ready!
Details
@ljharb ljharb deleted the sv-calling-convention branch Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.