Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise.{all,allSettled,race} should check resolve is a function before opening their iteratable #1912

Open
wants to merge 2 commits into
base: master
from

Conversation

@kmiller68
Copy link

kmiller68 commented Mar 22, 2020

This change makes promise.{all,allSettled,race} behave more like a canonical JS implementation. In particular, the resolve property is now checked to be callable before beginning iteration on the first argument.

This is the PR for #1902.

canonical JS implementation.  In particular, the resolve property is
now checked to be callable before beginning iteration on the first
argument.
@kmiller68 kmiller68 changed the title This change makes promise.{all,allSettled,race} behave more like a Promise.{all,allSettled,race} should check resolve is a function before opening their iteratable Mar 22, 2020
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
@ljharb ljharb requested review from michaelficarra, syg and tc39/ecma262-editors Mar 23, 2020
@ljharb
ljharb approved these changes Mar 23, 2020
ljharb added a commit to tc39/agendas that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.