Meta: Update ecmarkup version dependency #682

Merged
merged 1 commit into from Sep 2, 2016

Projects

None yet

7 participants

@mathiasbynens
Contributor

Note that the Travis configuration has been updated accordingly.

Ref. bterlson/ecmarkup#101.

@mathiasbynens mathiasbynens Meta: update ecmarkup version dependency 7a066cb
@mathiasbynens mathiasbynens changed the title from Meta: update ecmarkup version dependency to Meta: Update ecmarkup version dependency Aug 30, 2016
@ljharb ljharb commented on the diff Aug 30, 2016
.travis.yml
@@ -8,6 +8,6 @@ env:
language: node_js
node_js:
- - "5"
+ - "6"
@ljharb
ljharb Aug 30, 2016 Member

If you want to always point to latest, this can be "node"

@michaelficarra
michaelficarra Aug 30, 2016 Member

I prefer stable.

@ljharb
ljharb Aug 30, 2016 Member

"stable" has no meaning in semver (and thus in node/io.js >= 1.0), where everything is stable.

@domenic
domenic Aug 30, 2016 Member

It is short for "latest stable", which does have meaning.

@ljharb
ljharb Aug 30, 2016 Member

Sure, but the latest not-stable is 0.11 - so it's mostly meaningless. Either way, nvm is going to remove "stable" at some point, so "node" is a safer long-term choice.

@michaelficarra
michaelficarra Aug 30, 2016 edited Member

@ljharb [citation needed]

@ljharb
ljharb Aug 30, 2016 Member

I'm the sole maintainer of nvm and I intend to do it.

@domenic
domenic Aug 30, 2016 Member

You will break so many builds it will make left-pad look like a joke.

@UltCombo
UltCombo Aug 30, 2016 Contributor

@ljharb IMHO "node" is even more ambiguous than "stable". As far I can see, "node" could read as any Node.js version.

@domenic
domenic Aug 30, 2016 Member

Yeah, I definitely don't want to test against Node.js version "node" ^_^

@leobalter
leobalter Aug 30, 2016 Member

while latest is a nice terminology and maybe better than just "node", I agree stable is ambigous, include LTS versions to the options I would wonder for it.

If there's a chance for breaking changes, link stable to any stable release and do not update it anymore. It won't break anything and you'll have your deprecated alias.

@ljharb
ljharb Aug 30, 2016 Member

All of this is delightful discussion to have on the nvm repo when the time comes. For now, I'm suggesting "node" if we don't want to have to manually bump it to "7" etc in the future. If we don't like that, so be it.

@UltCombo
UltCombo Aug 30, 2016 Contributor

Back on topic, I believe testing against "stable"/"node"/LTS is an anti-pattern.

It means CI will unsolicitedly bump the major Node version whenever it becomes available without any previous test or knowledge from the authors. Major versions indicate breaking changes, and thus should be throughout tested (e.g. via a PR bumping the major version, like this one) in order to prevent breaking the build overnight.

@ljharb
ljharb Aug 30, 2016 Member

Fair counterpoint.

@michaelficarra
michaelficarra Aug 30, 2016 Member

@UltCombo I agree. We can have it be in the allowed failures so that, if a new version of node has incompatibilities, we will be notified but CI will not fail.

@bterlson
Member
bterlson commented Sep 2, 2016 edited

Looks good - I am fine with explicitly naming version 6 to test with. Note that ecmarkup 3.5 requires version 6 now.

@bterlson bterlson merged commit be9cae5 into tc39:master Sep 2, 2016
@jaychsu jaychsu added a commit to jaychsu/ecma262 that referenced this pull request Sep 7, 2016
@jaychsu jaychsu Merge remote-tracking branch 'upstream/master'
* upstream/master: (301 commits)
  Editorial: remove mistakenly committed change to eval-related super errors
  Normative: Point to the latest version of UTR15 (#681)
  Meta: update ecmarkup version dependency (#682)
  Editorial: Update a variable name in Annex B.3.3.1 to refer to the proper variable in FunctionDeclarationInstantiation's body, and add warning comments by all the spec algorithms monkey-patched by Annex B so that future refactoring doesn't create broken/dangling references in Annex B. (#677)
  Meta: update ecmarkup version dependency
  Editorial: dfn-ify 'goal symbol'
  Editorial: TypeArray -> TypedArray (#675)
  Editorial: Correct a wrong cross-reference in Annex C (#674)
  Editorial: tweak whitespace and articles (#667)
  Editorial: Tweak EnumerateObjectProperties informative definition (#656)
  Editorial: Rename variable (indx --> index) (#658)
  Editorial: Fix reference in ScriptEvaluation (#659)
  Editorial: Consistent `undefined or null` order (#660)
  Editorial: Refactor Array.prototype.toLocaleString (#662)
  Editorial: Tweak Array.prototype.join (#661)
  Simplify description of CreateImmutableBinding (#654)
  Normative: Resolve template argument references (#609)
  Editorial: Refactor Array.prototype.join (#638)
  Editorial: contains --> Contains in ModuleListItem SS
  Normative: Allow initializers in ForInStatement heads (#614)
  ...
a14f29d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment