toSpliced matches splice TypeError logic #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jan 9, 2022
ljharb
added a commit
to es-shims/Array.prototype.toSpliced
that referenced
this pull request
Mar 30, 2022
ljharb
added a commit
to es-shims/Array.prototype.toSpliced
that referenced
this pull request
Mar 31, 2022
zloirock
added a commit
to zloirock/core-js
that referenced
this pull request
Apr 2, 2022
…e result length is more than `MAX_SAFE_INTEGER` tc39/proposal-change-array-by-copy#59 (comment) tc39/proposal-change-array-by-copy#70
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Apr 17, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Apr 30, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Jun 10, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Jun 26, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Jun 26, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Jul 25, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Dec 6, 2022
petamoriken
added a commit
to petamoriken/float16
that referenced
this pull request
Dec 6, 2022
* Add `Float16Array#withReversed` * Add `Float16Array#withSorted` * Add `Float16Array#withSpliced` * Add `Float16Array#withAt` * use 'to' prefix for method names tc39/proposal-change-array-by-copy#50 * `.toSpliced` should throw a `TypeError` instead of `RangeError` tc39/proposal-change-array-by-copy#70 * `.with` should convert `value` up front tc39/proposal-change-array-by-copy#86 * Fix: `Float16Array#{toSorted, toSpliced}.length` * Avoid userland re-entrance after a read in `Float16Array#spliced` tc39/proposal-change-array-by-copy#89 * Remove `Float16Array#toSpliced` tc39/proposal-change-array-by-copy#88 (comment) * Optimize `Float16Array#toSorted` * Add types of Change Array by Copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #54
toSplicednow throws aTypeErrorwhen the array length exceedsMAX_SAFE_INTEGER, matching the check insplice.test262 PR merged: nicolo-ribaudo/test262#1