New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Name getter/setters as kind: "accessor" #200

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
4 participants
@littledan
Copy link
Member

littledan commented Jan 10, 2019

This doesn't change the expressiveness of decorators, but
it is designed to feel more intuitive when programming.

Addresses #173

@littledan

This comment has been minimized.

Copy link
Member

littledan commented Jan 10, 2019

@ljharb

ljharb approved these changes Jan 10, 2019

@pabloalmunia
Copy link
Contributor

pabloalmunia left a comment

Please, update TABLE.md

@littledan littledan force-pushed the accessor branch from ce3cb19 to 20d4b6d Jan 10, 2019

Normative: Name getter/setters as kind: "accessor"
This doesn't change the expressiveness of decorators, but
it is designed to feel more intuitive when programming.

@littledan littledan force-pushed the accessor branch from 20d4b6d to 27998c8 Jan 10, 2019

@littledan

This comment has been minimized.

Copy link
Member

littledan commented Jan 10, 2019

Fixed table and rebased. I'd like to land this soon, as I have more patches to do on top, but remember, reviews still welcome once it's landed.

@Lodin

Lodin approved these changes Jan 10, 2019

@littledan littledan merged commit 492bceb into master Jan 10, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@littledan littledan referenced this pull request Jan 15, 2019

Open

Stage 3 reviews #66

0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment