Remove Metadata #454
Merged
Remove Metadata #454
+24
−282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would also remove the ability of entangled decorators to get this |
|
Good point, I'll add back |
At the plenary today consensus was reached to move this proposal to stage 3 conditionally, with metadata being split out into a separate stage 2 proposal. The notion of "access" and the `access` object are highly related to metadata (it's pretty rare that you would have a use case for access outside of metadata), so I'm also removing it in this PR and will be adding it back in the stage 2 metadata proposal.
pzuraq
force-pushed
the
remove-metadata-and-access
branch
from
1159992
to
5c1cc15
Compare
Jack-Works
reviewed
Mar 29, 2022
| @@ -101,11 +98,10 @@ The context object also varies depending on the value being decorated. Breaking | |||
| - `"field"` | |||
| - `"accessor"` | |||
| - `name`: The name of the value, or in the case of private elements the _description_ of it (e.g. the readable name). | |||
| - `access`: An object containing methods to access the value on the instance. | |||
| - `access`: An object containing methods to access the value. These methods also get the _final_ value of the private element on the instance, not the current value passed to the decorator. This is important for most use cases involving access, such as type validators or serializers. See the section on Access below for more details. | |||
There was a problem hiding this comment.
Is this a normative change on the access object?
There was a problem hiding this comment.
No, this was how it always worked.
|
The split off proposal-decorator-metadata can be found here: https://github.com/tc39/proposal-decorator-metadata/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
At the plenary today consensus was reached to move this proposal to
stage 3 conditionally, with metadata being split out into a separate
stage 2 proposal. The notion of "access" and the
accessobject arehighly related to metadata (it's pretty rare that you would have a use
case for access outside of metadata), so I'm also removing it in this PR
and will be adding it back in the stage 2 metadata proposal.