Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Avoid trying to push from Travis PR builds #32

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Ms2ger
Copy link
Contributor

commented Jul 5, 2019

No description provided.

@@ -3,7 +3,7 @@
set -ev

# Pull requests and commits to other branches shouldn't try to deploy, just build to verify
if [[ "$TRAVIS_BRANCH" != master ]]; then
if [[ "$TRAVIS_BRANCH" != master || "$TRAVIS_PULL_REQUEST" != false ]]; then

This comment has been minimized.

Copy link
@ljharb

ljharb Jul 5, 2019

Member

this seems like it previously skipped the deploy on any non-master branch; and now will altos skip the deploy on PRs where the branch is master (like, from master to another branch), which in practice never happens. is this intended?

This comment has been minimized.

Copy link
@Ms2ger

Ms2ger Jul 8, 2019

Author Contributor

No, for PRs, $TRAVIS_BRANCH is the target branch; see https://docs.travis-ci.com/user/environment-variables/. (Don't ask me why…)

@ljharb

ljharb approved these changes Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.