Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #36 and #37 #42

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@FrankYFTang
Copy link
Collaborator

commented Jul 10, 2019

Improve text in the internal slot and use the right syntax.
This should close #36 and #37

index.html Outdated
<li>
[[LocaleData]].[[&lt;<var>locale</var>&gt;]] must have a types field for all locale values <var>locale</var>.
The value of this field must be a record, which must have fields with the names of the six display name types:
<code>"langauge"</code>, <code>"region"</code>, <code>"script"</code>, <code>"currency"</code>, <code>"dateField"</code>, and <code>"dateSymbol"</code>.

This comment was marked as resolved.

Copy link
@ljharb

ljharb Jul 10, 2019

Member
Suggested change
<code>"langauge"</code>, <code>"region"</code>, <code>"script"</code>, <code>"currency"</code>, <code>"dateField"</code>, and <code>"dateSymbol"</code>.
<code>"language"</code>, <code>"region"</code>, <code>"script"</code>, <code>"currency"</code>, <code>"dateField"</code>, and <code>"dateSymbol"</code>.
index.html Outdated
Each of these fields in turn must be a record, which must have fields with the names of the three display name styles:
<code>"narrow"</code>, <code>"short"</code>, and <code>"long"</code>.
The value of these fields in turn must be a record.
The values corresponding to the property keys are a String Value.

This comment has been minimized.

Copy link
@ljharb

ljharb Jul 10, 2019

Member

is “value” typically capitalized like this in 402?

spec.emu Outdated
<li>
[[LocaleData]].[[&lt;_locale_&gt;]] must have a types field for all locale values _locale_.
The value of this field must be a record, which must have fields with the names of the six display name types:
`"langauge"`, `"region"`, `"script"`, `"currency"`, `"dateField"`, and `"dateSymbol"`.

This comment was marked as resolved.

Copy link
@ljharb

ljharb Jul 10, 2019

Member
Suggested change
`"langauge"`, `"region"`, `"script"`, `"currency"`, `"dateField"`, and `"dateSymbol"`.
`"language"`, `"region"`, `"script"`, `"currency"`, `"dateField"`, and `"dateSymbol"`.
@FrankYFTang

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 12, 2019

@FrankYFTang FrankYFTang requested a review from sffc Jul 12, 2019

@sffc

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

I'm seeing changes from #43 in this PR. Can you check that you merged/rebased your branch correctly?

@FrankYFTang FrankYFTang force-pushed the FrankYFTang:editornit37 branch from 771c2bc to da683a6 Jul 12, 2019

@FrankYFTang

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 15, 2019

PTAL

1. Let _dataLocaleTypes_ be _dataLocaleData_.[[_type_]].
1. Let _fields_ be dataLocaleTypes.[[_style_]].
1. Set _displayNames_.[[Fields]] to _fields_.
1. Let _dataLocaleData_ be _localeData_.[[<_dataLocale_>]].

This comment has been minimized.

Copy link
@sffc

sffc Jul 15, 2019

Collaborator

I think you should use &gt; instead of raw <. At least that's how the numberformat spec works.

1. Set _displayNames_.[[Fields]] to _fields_.
1. Let _dataLocaleData_ be _localeData_.[[<_dataLocale_>]].
1. Let _types_ be _dataLocaleData_.[[types]].
1. Assert: _types_ is a record (see <emu-xref href="#sec-Intl.DisplayNames-internal-slots"></emu-xref>).

This comment has been minimized.

Copy link
@sffc

sffc Jul 15, 2019

Collaborator

I think Record is supposed to always be titlecase.

Each of these fields in turn must be a record, which must have fields with the names of the three display name styles:
`"narrow"`, `"short"`, and `"long"`.
The value of these fields in turn must be a record.
The values corresponding to the property keys are String values.

This comment has been minimized.

Copy link
@sffc

sffc Jul 15, 2019

Collaborator

Please describe in more detail what the fields in this record represent. I assume they are the identifiers that you pass to the .of method? Do you have language for what you call those identifiers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.