Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Normative: Add numberingSystem option bag entry #108

Merged
merged 1 commit into from May 9, 2019

Conversation

littledan
Copy link
Member

Analogy to tc39/ecma402#175

@littledan
Copy link
Member Author

cc @FrankYFTang @Ms2ger

Copy link
Contributor

@FrankYFTang FrankYFTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankYFTang
Copy link
Contributor

tracking bug for v8 filed https://bugs.chromium.org/p/v8/issues/detail?id=9190

@@ -21,12 +21,16 @@ <h1>InitializeRelativeTimeFormat ( _relativeTimeFormat_, _locales_, _options_ )<
1. Let _options_ be ? ToObject(_options_).
1. Let _opt_ be a new Record.
1. Let _matcher_ be ? GetOption(_options_, `"localeMatcher"`, `"string"`, «`"lookup"`, `"best fit"`», `"best fit"`).
1. Let _numberingSystem_ be ? GetOption(_options_, `"numberingSystem"`, `"string"`, *undefined*, *undefined*).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should keep these new lines below the line

Set _opt_.[[LocaleMatcher]] to _matcher_.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordered; thanks.

@littledan littledan merged commit b44b14f into master May 9, 2019
@littledan
Copy link
Member Author

Merging based on discussion in the May 2019 ECMA-402 meeting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants