Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LogicalExpression to ShortCircuitExpression #50

Open
wants to merge 1 commit into
base: master
from

Conversation

@rkirsling
Copy link
Member

commented Aug 8, 2019

A nitpick to be sure, but we do want to set a good example for the community at large. 馃槃

The word "logical" means "truth(iness)-oriented", so (unless we mean ternary logic now 馃槢) I think it's important not to bucket our nullish-oriented ?? with ||, &&, and ! in this way. The thing that ?? truly has in common with || and && is short-circuiting, so it's probably best to say just that.

@ljharb

ljharb approved these changes Aug 8, 2019

Copy link
Member

left a comment

I typically refer to pipes and amps as 鈥渧alue selection operators鈥, but perhaps this is more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.